Review main Merged

69397[TASK] Remove possibility to use ext:rsaauth

Torben Hansen CR +2 V +2 Hard +26 −242 updated 06/10/21, 15:54

Commit message

Usage of FriendsOfTYPO3/rsaauth is pretty low and there
is no reason to support the extension any more in TYPO3 11.

This patch removes all ext:rsaauth related code.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 13

Review log 1723

  1. Torben Hansen uploaded patch set 1 06/04/21, 12:55

  2. core-ci voted on patch set 1 V +1 06/04/21, 13:07 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12160

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/09/21, 21:53

  4. Christian Kuhn uploaded patch set 2 06/09/21, 22:12

  5. Christian Kuhn uploaded patch set 3 06/09/21, 22:15

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 06/09/21, 22:15

  7. core-ci voted on patch set 3 V -1 06/09/21, 22:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12252

  8. core-ci voted on patch set 2 V -1 06/09/21, 22:23 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12251

  9. Christian Kuhn uploaded patch set 4 06/09/21, 22:32

  10. core-ci voted on patch set 4 V -1 06/09/21, 22:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12254

  11. Christian Kuhn uploaded patch set 5 06/09/21, 22:35

  12. core-ci voted on patch set 5 V +1 06/09/21, 22:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12256

  13. Andreas Kienast commented on patch set 5 06/10/21, 14:59

    SilentConfigurationUpgradeService.php:231

    By reading the code I wonder whether this doesn't make the whole setting `BE/loginSecurityLevel` obsolete.
  14. Oli Bartsch commented on patch set 5 06/10/21, 15:07

    SilentConfigurationUpgradeService.php:231 Reply

    It indeed does. We discussed this already and as far as I remember, decided to drop this in a separate patch. Would you agree?
  15. Andreas Kienast commented on patch set 5 06/10/21, 15:09

    SilentConfigurationUpgradeService.php:231 Reply

    I'm totally fine with that. :)
  16. Christian Kuhn commented on patch set 5 V +1 CR +1 06/10/21, 15:17

    SilentConfigurationUpgradeService.php:231 Reply Unresolved

    what oli said ;) will be a separate patch.
  17. Andreas Kienast commented on patch set 5 CR -1 06/10/21, 15:35

    on it
  18. Andreas Kienast uploaded patch set 6 06/10/21, 15:38

  19. Andreas Kienast voted on patch set 6 V +1 CR +1 06/10/21, 15:39

  20. Oli Bartsch voted on patch set 6 V +1 CR +1 06/10/21, 15:49

  21. core-ci voted on patch set 6 V +1 06/10/21, 15:51 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12274

  22. Christian Kuhn voted on patch set 6 V +2 CR +2 06/10/21, 15:53

  23. Christian Kuhn merged patch set 7 06/10/21, 15:54