Review main Merged

69399[TASK] Remove "sha1" from sys_file searchFields

Guido Schmechel CR +2 V +2 Easy +1 −1 updated 06/09/21, 21:45

Commit message

To avoid confusion for the editor, the "sha1" field
is now removed from the searchFields of sys_file.

Those who wish to continue searching this field can
adapt the corresponding TCA via TCA overrides.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1013

  1. Guido Schmechel uploaded patch set 1 06/04/21, 19:05

  2. core-ci voted on patch set 1 V +1 06/04/21, 19:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12164

  3. Oli Bartsch commented on patch set 1 V +1 CR +1 06/04/21, 19:21

    Nice, already did some cleanup for sys_file_reference a while ago. https://review.typo3.org/c/Packages/TYPO3.CMS/+/68171
  4. Oli Bartsch updated the commit message in patch set 2 06/04/21, 20:05

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 06/04/21, 20:06

  6. core-ci voted on patch set 2 V +1 06/04/21, 20:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12166

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/09/21, 21:30

  8. Christian Kuhn voted on patch set 2 V 0 CR 0 06/09/21, 21:32

  9. Christian Kuhn updated the commit message in patch set 3 06/09/21, 21:32

  10. Oli Bartsch voted on patch set 3 V +1 CR +1 06/09/21, 21:35

  11. core-ci voted on patch set 3 V +1 06/09/21, 21:41 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12249

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 06/09/21, 21:45

  13. Christian Kuhn merged patch set 4 06/09/21, 21:45