Review main Merged

69400[TASK] Sort extension list by update state

Oli Bartsch CR +2 V +2 Easy +36 −11 updated 06/09/21, 21:33

Commit message

Extension updates are important, since they may
contain security fixes. Therefore, in non-composer
based installations, the extension listing in the
EXT:extensionmanager "Installed extensions" view
is now always sorted by the extensions' update state,
as soon as one extension can be updated.

For composer based projects, the behaviour does not
change, since updating extensions is usually done
via CLI and chaning the sorting can still be done
manually in the module.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1317

  1. Oli Bartsch uploaded patch set 1 06/04/21, 20:02

  2. core-ci voted on patch set 1 V -1 06/04/21, 20:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12165

  3. Oli Bartsch uploaded patch set 2 06/04/21, 20:09

  4. core-ci voted on patch set 2 V +1 06/04/21, 20:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12167

  5. Jochen Roth voted on patch set 2 V +1 CR +1 06/08/21, 08:19

  6. Christian Kuhn commented on patch set 2 06/08/21, 12:42

    need testing advise, guess i'm stupid ;) ... base question: do we really need to have a toggle for this?
  7. Oli Bartsch commented on patch set 2 06/08/21, 13:53

    Reply

    > need testing advise, guess i'm stupid ;) ... base question: do we really need to have a toggle for this? In a non-composer installation: * Go to Extension manager > "Get Extensions" * Search for "mfa_hotp" > Click on either the name, key or version to get to the "detail view" * Install version 0.1.0 * Go back to "Installed extensions" * The extension contains an "update" button but is not on the top * Apply patch => extension is displayed at the top of the list Now you can also test the TSconfig option. IMO we need a toggle since the used framework "tablesort" does not provide the possibility to sort by multiple columns (AFAIK). Therefore when sorting by update state the remaining extensions are sorted "randomly". This may bother people, especially in composer mode, where updating extensions is done via CLI. That's why I think an admin should have the possibility to decide whether this kind of sorting should be applied or not.
  8. Christian Kuhn commented on patch set 2 06/09/21, 11:35

    Thanks. I was able to reproduce now. I still think the toggle could be dropped and the issue is a task for v11.
  9. Oli Bartsch uploaded patch set 3 06/09/21, 15:21

  10. Oli Bartsch commented on patch set 3 06/09/21, 15:22

    Reply

    Done
  11. core-ci voted on patch set 3 V +1 06/09/21, 15:32 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12229

  12. Christian Kuhn uploaded patch set 4 06/09/21, 16:09

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 06/09/21, 16:09

  14. Jochen Roth voted on patch set 4 V +1 CR +1 06/09/21, 16:10

  15. core-ci voted on patch set 4 V +1 06/09/21, 16:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12232

  16. Oli Bartsch voted on patch set 4 V +2 CR +2 06/09/21, 21:33

  17. Oli Bartsch merged patch set 5 06/09/21, 21:33