69404[WIP][FEATURE] Implement UX improvements in module bar and action buttons
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 20
- Build/Sources/Sass/component/_buttons.scss+23 −4
- Build/Sources/Sass/component/_card.scss+4 −0
- Build/Sources/Sass/component/_modal.scss+1 −0
- Build/Sources/Sass/component/_module.scss+2 −2
- Build/Sources/Sass/component/_svgtree.scss+1 −1
- Build/Sources/Sass/scaffold/_modulemenu.scss+50 −8
- Build/Sources/Sass/scaffold/_scaffold.scss+14 −1
- Build/Sources/Sass/scaffold/_topbar.scss+41 −4
- Build/Sources/Sass/typo3/_main_form.scss+6 −0
- Build/Sources/Sass/variables/_main.scss+10 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+6 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Toolbar.ts+1 −1
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+19 −0
- typo3/sysext/backend/Resources/Private/Templates/ModuleMenu/Main.html+8 −1
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Toolbar.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Feature-94282-ImplementUXImprovementsInModuleBarAndActionButtons.rstnew+73 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/ModuleMenuButtonCest.php+4 −4
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
Review log 1726
Show 1 earlier messages
-
Jonas Eberle uploaded patch set 1 06/07/21, 08:52
-
core-ci voted on patch set 1 V -1 06/07/21, 09:03 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12187
-
Jonas Eberle uploaded patch set 2 06/07/21, 12:22
-
core-ci voted on patch set 2 V -1 06/07/21, 12:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12193
-
Jonas Eberle uploaded patch set 3 06/07/21, 13:06
-
core-ci voted on patch set 3 V +1 06/07/21, 13:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12194
-
Oli Bartsch commented on patch set 3 V -1 06/07/21, 15:50
Hi Jonas, thank you for your contribution. Currently there is neither a commit message nor a feature rst, describing the change. Unfortunately also the forge issue just contains two screenshots. Since this patch has quite some visible impact, please allow me to ask some questions on this: * Did you discuss this with the a11y team and if so, did they approve it? * Did you talk to Benjamin Kott regarding the black & white icons, since AFAIK such icons are currently not included in the TYPO3.Icons package? * Is there a concept for this change and if so, where can I find it? * What exactly is the desired improvement here and how did you come to it? Is this the result of evaluating statistics / analyses of current UI best-practices or is this the result of some audit? * Are there further patches in this area planned? Please don’t get me wrong. I’m all for improving the UX/UI in the backend. This just feels as if it needs some broader coordination and sign-offs by not only the core team, but other groups like the a11y and icon team, too. Especially since in the last couple of weeks / months, a lot of patches were created to improve and regain consistency in the backend after the bootstrap update in 11.0. Also the a11y team heavily worked on improving the backend by adding keyboard navigation to module menu / context menu and by unifying button styles, contrasts and so on. I'll vote this -1 for now, until the basics are sorted out. Hope this is ok. -
Rachel Foucard updated the commit message in patch set 4 06/07/21, 16:50
-
core-ci voted on patch set 4 V +1 06/07/21, 17:00 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12197
-
Rachel Foucard commented on patch set 4 06/07/21, 17:01
Reply
Hello Oliver, I updated the commit message, I hope this will answer your questions. There are further patches planned, but we take care that each one is mergeable separatly. The Structured Content Initiative has a monthly call each last wednesday of a the month, we would be glad to invite you and answer all your questions about what we plan. -
Oli Bartsch commented on patch set 4 06/07/21, 22:23
Reply
Hi Rachel, thanks for updating the commit message. Since this patch is declared as feature it would also need a feature rst. Therefore, you can have a look at https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/AddingDocumentation/Index.html for more information. > The Structured Content Initiative has a monthly call each last wednesday of a the month, we would be glad to invite you and answer all your questions about what we plan. Great, I would be glad to join the next call. > I hope this will answer your questions Unfortunately most of the questions are still unanswered since the commit message only described what was done but not why and more importantly how this will improve the UX. That’s actually why I asked for the concept and on which basis (audits / analysis / best-practices) this was developed. Especially since you already confirmed, there will be more patches in this area, I assume there has to be some concept. Ideally containing more insights about the background, how you got there and how this will solve editors problems. Regarding the icons. The reason for asking whether you talked to Benjaming Kott is, that I’m unsure if changing the icons’ color via CSS is the right way to go. On the one hand, extension authors are not aware of this and their custom module icons may break with this change. On the other hand, I personally would prefer extending the existing Icons API to support this kind of icon style - similar to the size options.ch -
Oli Bartsch commented on patch set 4 06/07/21, 22:41
Reply
I also did some testing and it seems that the current state would lead to some problems. Examples, which struck me straight away: * Since buttons do not longer have a background color, it’s now generally much more difficult to distinguish between normal text and links / buttons * While some components now have round borders (e.g. buttons, inputs, modals), others have not (e.g. alerts, callouts, panels) * If the module menu is minimized, the module entries are not longer divided by the module groups and it’s therefore not longer possible to differentiate or collapse them * The module header is not longer recognizable as such. Especially in modules with just buttons, e.g. the redirects module -
Jonas Eberle commented on patch set 4 06/09/21, 08:11
We'll add a feature RST tonight describing the reasoning and going into detail what changed and why. Also I hope we can outline the context and goals of backend work of the Structured Content Initiative. -
Jonas Eberle commented on patch set 4 06/09/21, 08:12
We'll also have a look at the reported issues. Thank you for testing, Oliver! -
Jonas Eberle uploaded patch set 5 06/09/21, 18:53
-
Jonas Eberle updated the commit message in patch set 6 06/09/21, 18:54
-
Jonas Eberle uploaded patch set 7 06/09/21, 18:58
-
core-ci voted on patch set 5 V +1 06/09/21, 19:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12236
-
core-ci voted on patch set 6 V +1 06/09/21, 19:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12237
-
Jonas Eberle uploaded patch set 8 06/09/21, 19:08
-
core-ci voted on patch set 7 V +1 06/09/21, 19:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12238
-
core-ci voted on patch set 8 V +1 06/09/21, 19:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12239
-
Jonas Eberle uploaded patch set 9 06/11/21, 06:15
-
core-ci voted on patch set 9 V +1 06/11/21, 06:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12292
-
Jonas Eberle commented on patch set 9 06/11/21, 07:49
We are about to find a saner way for the icon changes via the TYPO3.Icons repository. -
Jonas Eberle abandoned the change 07/07/21, 17:34
UX Team will be founded and eventually come up with such changes