Review main Merged

69412[TASK] Avoid ObjectManager in ext:fluid RenderingContext

Christian Kuhn CR +2 V +2 Hard +219 −43 updated 06/09/21, 16:05

Commit message

RenderingContext is a good case for a class that creates
"arbitrary" objects: The PreProcessor class names are
retrieved from global configuration in order to be
instantiated.

This initialization is moved into a (install tool mode
compatible) factory in order to transform ObjectManager
into a fallback layer for PreProcessors that are
not defined in the newer PSR container.
Therefore $container->has() is used prior to $container->get(),
in order to fallback to ObjectManager for objects that can't be
retrieved – due to missing configuration – via ContainerInterface yet.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 8

Review log 1627

Show 12 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/08/21, 10:11

  2. core-ci voted on patch set 1 V -1 06/08/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12206

  1. Christian Kuhn uploaded patch set 2 06/08/21, 10:40

  2. core-ci voted on patch set 2 V -1 06/08/21, 10:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12209

  3. Christian Kuhn uploaded patch set 3 06/08/21, 10:44

  4. core-ci voted on patch set 3 V -1 06/08/21, 10:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12210

  5. Benjamin Franzke uploaded patch set 4 06/08/21, 11:29

  6. Benjamin Franzke uploaded patch set 5 06/08/21, 11:38

  7. core-ci voted on patch set 4 V -1 06/08/21, 11:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12211

  8. core-ci voted on patch set 5 V -1 06/08/21, 11:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12212

  9. Benjamin Franzke uploaded patch set 6 06/08/21, 12:23

  10. core-ci voted on patch set 6 V -1 06/08/21, 12:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12214

  11. Benjamin Franzke uploaded patch set 7 06/08/21, 12:34

  12. core-ci voted on patch set 7 V -1 06/08/21, 12:45 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12215

  13. Benjamin Franzke uploaded patch set 8 06/08/21, 12:48

  14. core-ci voted on patch set 8 V +1 06/08/21, 12:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12216

  15. Benjamin Franzke uploaded patch set 9 06/08/21, 13:11

  16. core-ci voted on patch set 9 V +1 06/08/21, 13:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12217

  17. Benjamin Franzke uploaded patch set 10 06/08/21, 13:39

  18. core-ci voted on patch set 10 V +1 06/08/21, 13:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12219

  19. Christian Kuhn commented on patch set 10 CR -1 06/09/21, 09:05

    Great work Benjamin! Thanks a lot. I'll -1 for minor details and will push again.
  20. Christian Kuhn uploaded patch set 11 06/09/21, 15:38

  21. core-ci voted on patch set 11 V +1 06/09/21, 15:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12231

  22. Benjamin Franzke voted on patch set 11 V +1 CR +1 06/09/21, 15:53

  23. Oli Bartsch voted on patch set 11 V +1 CR +1 06/09/21, 15:59

  24. Christian Kuhn voted on patch set 11 V +2 CR +2 06/09/21, 16:02

  25. Christian Kuhn merged patch set 12 06/09/21, 16:05