69412[TASK] Avoid ObjectManager in ext:fluid RenderingContext
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benjamin Franzke +1
- Oli Bartsch +1
- core-ci +1 CI
Issues 2
Files 8
- typo3/sysext/extbase/Configuration/Services.yaml+4 −0
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+27 −36
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContextFactory.phpnew+105 −0
- typo3/sysext/fluid/Classes/View/AbstractTemplateView.php+2 −2
- typo3/sysext/fluid/Classes/View/StandaloneView.php+3 −5
- typo3/sysext/fluid/Classes/ServiceProvider.phpnew+55 −0
- typo3/sysext/fluid/Configuration/Services.yaml+22 −0
- typo3/sysext/fluid/composer.json+1 −0
Review log 1627
Show 12 earlier messages
-
Christian Kuhn uploaded patch set 1 06/08/21, 10:11
-
core-ci voted on patch set 1 V -1 06/08/21, 10:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12206
-
Christian Kuhn uploaded patch set 2 06/08/21, 10:40
-
core-ci voted on patch set 2 V -1 06/08/21, 10:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12209
-
Christian Kuhn uploaded patch set 3 06/08/21, 10:44
-
core-ci voted on patch set 3 V -1 06/08/21, 10:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12210
-
Benjamin Franzke uploaded patch set 4 06/08/21, 11:29
-
Benjamin Franzke uploaded patch set 5 06/08/21, 11:38
-
core-ci voted on patch set 4 V -1 06/08/21, 11:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12211
-
core-ci voted on patch set 5 V -1 06/08/21, 11:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12212
-
Benjamin Franzke uploaded patch set 6 06/08/21, 12:23
-
core-ci voted on patch set 6 V -1 06/08/21, 12:32 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12214
-
Benjamin Franzke uploaded patch set 7 06/08/21, 12:34
-
core-ci voted on patch set 7 V -1 06/08/21, 12:45 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12215
-
Benjamin Franzke uploaded patch set 8 06/08/21, 12:48
-
core-ci voted on patch set 8 V +1 06/08/21, 12:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12216
-
Benjamin Franzke uploaded patch set 9 06/08/21, 13:11
-
core-ci voted on patch set 9 V +1 06/08/21, 13:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12217
-
Benjamin Franzke uploaded patch set 10 06/08/21, 13:39
-
core-ci voted on patch set 10 V +1 06/08/21, 13:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12219
-
Christian Kuhn commented on patch set 10 CR -1 06/09/21, 09:05
Great work Benjamin! Thanks a lot. I'll -1 for minor details and will push again. -
Christian Kuhn uploaded patch set 11 06/09/21, 15:38
-
core-ci voted on patch set 11 V +1 06/09/21, 15:49 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12231
-
Benjamin Franzke voted on patch set 11 V +1 CR +1 06/09/21, 15:53
-
Oli Bartsch voted on patch set 11 V +1 CR +1 06/09/21, 15:59
-
Christian Kuhn voted on patch set 11 V +2 CR +2 06/09/21, 16:02
-
Christian Kuhn merged patch set 12 06/09/21, 16:05