Review main Merged

69418[BUGFIX] Add uid field to fieldDefinitions in EXT:seo

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/09/21, 21:08

Commit message

EXT:seo defines two additional types for "Page Overview"
in the info module.

Since the special uid field, which has a special treatment
in PageInformationController, was previously missing, no
view and no edit options were displayed.

Besides the already existing special treatments, in master,
the field is also used to determine the row tag to be used
(either `<th>`or `<td>`). Therefore, the two EXT:seo types
previously always used `<th>`, which leads to all cells were
bold (in at least the chrome browser, due to user agent styles).

This is now fixed by adding the special uid field to the
mod.web_info.fieldDefinitions declaration in EXT:seo.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/09/21, 16:52

  2. core-ci voted on patch set 1 V +1 06/09/21, 16:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12234

  3. Christian Kuhn commented on patch set 1 V +1 CR +1 06/09/21, 17:02

    wah. Ok, pageInformationController should have a general re-work ... fine with the patch for now.
  4. Jochen Roth voted on patch set 1 V +1 CR +1 06/09/21, 17:44

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 06/09/21, 21:08

  6. Oli Bartsch merged patch set 2 06/09/21, 21:08