69419[TASK] Avoid ObjectManager in ext:fluid ViewHelperResolver
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Benni Mack +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Benni Mack +1
- core-ci +1 CI
Issues 3
Files 8
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContext.php+1 −0
- typo3/sysext/fluid/Classes/Core/Rendering/RenderingContextFactory.php+13 −11
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolver.php3+40 −19
- typo3/sysext/fluid/Classes/Core/ViewHelper/ViewHelperResolverFactory.php2new+55 −0
- typo3/sysext/fluid/Classes/ViewHelpers/Format/CropViewHelper.php+1 −4
- typo3/sysext/fluid/Classes/ServiceProvider.php+8 −4
- typo3/sysext/fluid/Configuration/Services.yaml+83 −0
- typo3/sysext/fluid/Tests/Unit/Core/ViewHelper/ViewHelperResolverTest.php+12 −16
Review log 1926
Show 1 earlier messages
-
Christian Kuhn uploaded patch set 1 06/09/21, 19:22
-
core-ci voted on patch set 1 V +1 06/09/21, 19:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12240
-
Oli Bartsch voted on patch set 1 V +1 06/10/21, 20:16
-
Benni Mack voted on patch set 1 CR +1 06/12/21, 10:55
-
Benjamin Franzke commented on patch set 1 CR -1 06/12/21, 16:15
-
Christian Kuhn commented on patch set 1 06/12/21, 16:24
ViewHelperResolver.php:82Replyyeah. will do. -
Christian Kuhn uploaded patch set 2 06/14/21, 22:03
-
Christian Kuhn uploaded patch set 3 06/14/21, 22:12
-
Christian Kuhn commented on patch set 3 CR -1 06/14/21, 22:13
still not perfect, since OM is now used for all VH's of base typo3Fluid package ... -
core-ci voted on patch set 2 V -1 06/14/21, 22:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12436
-
core-ci voted on patch set 3 V -1 06/14/21, 22:22 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12437
-
Christian Kuhn uploaded patch set 4 06/14/21, 22:22
-
core-ci voted on patch set 4 V -1 06/14/21, 22:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12438
-
Christian Kuhn uploaded patch set 5 06/16/21, 22:15
-
core-ci voted on patch set 5 V +1 06/16/21, 22:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12515
-
Christian Kuhn commented on patch set 5 06/16/21, 22:27
ViewHelperResolver.php:82ReplyDone -
Benni Mack commented on patch set 5 06/17/21, 12:12
ViewHelperResolverFactory.php:33I think this should be marked as @internal -
Christian Kuhn uploaded patch set 6 06/17/21, 13:33
-
Christian Kuhn commented on patch set 6 06/17/21, 13:34
ViewHelperResolverFactory.php:33ReplyDone via final keyword. -
Christian Kuhn uploaded patch set 7 06/17/21, 13:35
-
core-ci voted on patch set 6 V +1 06/17/21, 13:43 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12541
-
core-ci voted on patch set 7 V +1 06/17/21, 13:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12542
-
Benni Mack voted on patch set 7 V +1 CR +1 06/17/21, 14:09
-
Benjamin Franzke voted on patch set 7 CR +1 06/17/21, 18:57
-
Benjamin Franzke voted on patch set 7 V +2 CR +2 06/17/21, 18:59
-
Benjamin Franzke merged patch set 8 06/17/21, 18:59
ViewHelperResolver.php:82