6942[BUGFIX] PHP warning if open_basedir is enabled
Commit message
Review
-
Code review CR +2
- Steffen Ritter +2
- Oliver Klee +1
- Markus Klein +1
-
Verified V +2
- Steffen Ritter +2
- Markus Klein +1
Issues 1
Files 1
Review log 32
Show 7 earlier messages
-
Dmitry Dulepov commented on patch set 2 08/19/12, 13:23
Thank you :) -
Dmitry Dulepov commented on patch set 2 08/19/12, 13:23
Markus, I cannot find any differences in patch #2. Could you describe what was changed, please? :) Thanks! -
Dmitry Dulepov commented on patch set 2 08/19/12, 13:23
(1 inline comment) -
Dmitry Dulepov uploaded patch set 3 08/19/12, 13:23
-
Dmitry Dulepov uploaded patch set 4 08/19/12, 13:23
-
Dmitry Dulepov uploaded patch set 5 08/19/12, 13:23
-
Dmitry Dulepov commented on patch set 5 08/19/12, 13:23
(1 inline comment)
-
Markus Klein uploaded patch set 2 08/19/12, 13:23
-
Markus Klein commented on patch set 2 08/19/12, 13:23
Just a typo in the commit message. -
Markus Klein commented on patch set 5 08/19/12, 13:23
Looks good to me, but someone else must approve -
Markus Klein uploaded patch set 6 08/19/12, 13:23
-
Markus Klein commented on patch set 6 08/19/12, 13:23
Verified; Looks good to me, but someone else must approve Fixed typo in commit message. I cannot test this one, but by reading this issue should be fixed. Therefore V:+1 -
Markus Klein commented on patch set 6 08/19/12, 13:23
Is this really an issue in 4.5? Code looks completely different. -
Oliver Klee commented on patch set 2 08/19/12, 13:23
(2 inline comments)class.t3lib_befunc.php:947Instead of introducing the error suppression, can't we check if the content is XML (by checking whether it contains < or >)?class.t3lib_befunc.php:4367Please don't add any Whitespace or LF after the ?>.class.t3lib_befunc.php:4367ReplyOkay, the whitespace actually gets removed. So please just ignore this particular comment. :-) -
Oliver Klee commented on patch set 2 08/19/12, 13:23
(1 inline comment) -
Oliver Klee commented on patch set 2 08/19/12, 13:23
(1 inline comment) -
Oliver Klee commented on patch set 4 08/19/12, 13:23
Looks good. +1 for an updated patch if you fix the indentation. -
Oliver Klee commented on patch set 5 08/19/12, 13:23
(1 inline comment) -
Oliver Klee commented on patch set 5 1 comment 08/19/12, 13:23
Looks good to me, but someone else must approve -
Oliver Klee commented on patch set 6 08/19/12, 13:23
Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 1 08/19/12, 13:23
Verified; Looks good to me, but someone else must approve -
Steffen Ritter commented on patch set 6 V 0 08/19/12, 13:23
by team member; Looks good to me, approved -
Steffen Ritter merged patch set 6 08/19/12, 13:23
-
Sebastian Fischer commented on patch set 2 08/19/12, 13:23
I would prefer that you didn't submit thisclass.t3lib_befunc.php:947ReplyI think something like this will do the job if (!preg_match('~^<.*>.*</.*>$~', $dataStructRec[$fName]) && is_file(PATH_site . $dataStructRec[$fName])) { -
Sebastian Fischer commented on patch set 4 08/19/12, 13:23
Looks good to me, but someone else must approve Looks good to me. In general a < wont be present in a file name to should work as expected. Just one point. There are two lines not correct indented. I dont wont to block this just by nitpicking. -
Mr. Jenkins commented on patch set 1 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2507/ : SUCCESS -
Mr. Jenkins commented on patch set 2 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2509/ : SUCCESS -
Mr. Jenkins commented on patch set 3 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2602/ : SUCCESS -
Mr. Jenkins commented on patch set 4 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2603/ : SUCCESS -
Mr. Jenkins commented on patch set 5 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2605/ : SUCCESS -
Mr. Jenkins commented on patch set 6 08/19/12, 13:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2712/ : SUCCESS -
Ernesto Baschny commented on patch set 6 08/19/12, 13:23
Not an issue for 4.5, as "support for FlexForm file reference" was a new feature of TYPO3 4.6.0 (0627d1bb2e7780d0025e19735e8d86a9803e8e72).