Review main Merged

69426[BUGFIX] Remove an obsolete Services.yaml definition

Christian Kuhn CR +2 V +2 Easy +0 −4 updated 06/10/21, 11:13

Commit message

The namespace of core TypoScriptService is
TYPO3\CMS\Core\TypoScript, not TYPO3\CMS\Core\Service.

The entry is thus obsolete and can be dropped. The
service with correct name is already handled by ext:core
ServiceProvider.php.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 57

  1. Christian Kuhn uploaded patch set 1 06/10/21, 10:41

  2. Christian Kuhn updated the commit message in patch set 2 06/10/21, 10:42

  3. Oli Bartsch voted on patch set 2 V +1 CR +1 06/10/21, 10:43

  4. core-ci voted on patch set 1 V +1 06/10/21, 10:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12263

  5. core-ci voted on patch set 2 V +1 06/10/21, 10:53 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12264

  6. Georg Ringer voted on patch set 2 V +2 CR +2 06/10/21, 11:13

  7. Georg Ringer merged patch set 3 06/10/21, 11:13