Review main Merged

69427[BUGFIX] Do not render clipboard actions for page translations

Oli Bartsch CR +2 V +2 Easy +6 −2 updated 06/10/21, 16:05

Commit message

Recordlist features the clipboard functionality. When activated,
multiple clipboard actions, such as "copy" or "edit marked", are
displayed in each tables' header.

Since translated records can never be selected, this led to
exceptions and JavaScript errors when using such action
on the "Page Translations" table.

This is now fixed by not rendering those actions for this
special table.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oli Bartsch uploaded patch set 1 06/10/21, 11:09

  2. core-ci voted on patch set 1 V +1 06/10/21, 11:17 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12265

  3. Christian Kuhn commented on patch set 1 06/10/21, 11:22

    could the 3 buttons for page translation rows vanish, too, then?
  4. Oli Bartsch uploaded patch set 2 06/10/21, 12:29

  5. Oli Bartsch commented on patch set 2 06/10/21, 12:30

    Reply

    Done
  6. core-ci voted on patch set 2 V +1 06/10/21, 12:38 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12269

  7. Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 14:46

  8. Christian Kuhn voted on patch set 2 V +1 CR +1 06/10/21, 15:56

  9. Oli Bartsch voted on patch set 2 V +2 CR +2 06/10/21, 16:05

  10. Oli Bartsch merged patch set 3 06/10/21, 16:05