69428[TASK] Avoid ObjectManager->get() for ext:form TypoScriptService
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Jochen Roth +1
-
Verified V +2 Done
- Oli Bartsch +2
- Jochen Roth +1
- core-ci +1 CI
Issues 3
Files 5
- typo3/sysext/form/Classes/Controller/FormFrontendController.php+1 −1
- typo3/sysext/form/Classes/Mvc/Configuration/ConfigurationManager.php+1 −1
- typo3/sysext/form/Classes/Mvc/Configuration/TypoScriptService.php+6 −13
- typo3/sysext/form/Configuration/Services.yaml+3 −0
- typo3/sysext/form/Tests/Unit/Controller/FormFrontendControllerTest.php+2 −25
Review log 57
-
Christian Kuhn uploaded patch set 1 06/10/21, 11:13
-
core-ci voted on patch set 1 V -1 06/10/21, 11:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12266
-
Christian Kuhn uploaded patch set 2 06/10/21, 11:19
-
core-ci voted on patch set 2 V +1 06/10/21, 11:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12267
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 11:35
-
Oli Bartsch voted on patch set 2 V +2 CR +2 06/10/21, 11:48
-
Oli Bartsch merged patch set 3 06/10/21, 11:48