Review main Merged

69428[TASK] Avoid ObjectManager->get() for ext:form TypoScriptService

Christian Kuhn CR +2 V +2 Normal +13 −40 updated 06/10/21, 11:48

Commit message

Make ext:form TypoScriptService injectable and adapt
consumers. Fixes a broken $this->objectManager call
from #94093 in ConfigurationManager.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 3

Files 5

Review log 57

  1. Christian Kuhn uploaded patch set 1 06/10/21, 11:13

  2. core-ci voted on patch set 1 V -1 06/10/21, 11:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12266

  3. Christian Kuhn uploaded patch set 2 06/10/21, 11:19

  4. core-ci voted on patch set 2 V +1 06/10/21, 11:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12267

  5. Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 11:35

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 06/10/21, 11:48

  7. Oli Bartsch merged patch set 3 06/10/21, 11:48