69431[TASK] Avoid ObjectManager->get() for ext:form FormPersistenceManagerInterface
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- Oliver Klee +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/form/Classes/Hooks/DataStructureIdentifierHook.php+1 −2
- typo3/sysext/form/Classes/Hooks/FormPagePreviewRenderer.php+1 −2
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+2 −2
- typo3/sysext/form/Configuration/Services.yaml+4 −0
- typo3/sysext/form/Tests/Unit/Hooks/DataStructureIdentifierHookTest.php+2 −7
Review log 79
-
Christian Kuhn uploaded patch set 1 06/10/21, 13:30
-
core-ci voted on patch set 1 V -1 06/10/21, 13:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12271
-
Christian Kuhn uploaded patch set 2 06/10/21, 13:44
-
Oliver Klee voted on patch set 2 CR +1 06/10/21, 13:45
-
core-ci voted on patch set 2 V +1 06/10/21, 13:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12272
-
Oli Bartsch voted on patch set 2 V +1 CR +1 06/10/21, 14:38
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 14:39
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/10/21, 14:41
-
Christian Kuhn merged patch set 3 06/10/21, 14:41