Review main Merged

69454[TASK] Avoid ObjectManager in ext:form TranslationService

Christian Kuhn CR +2 V +2 Normal +32 −89 updated 06/10/21, 19:25

Commit message

Extbase ConfigurationManager is already configured to
be injectable. Use this in TranslationService.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 811

  1. Christian Kuhn uploaded patch set 1 06/10/21, 16:21

  2. Christian Kuhn updated the commit message in patch set 2 06/10/21, 16:23

  3. core-ci voted on patch set 1 V -1 06/10/21, 16:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12279

  4. core-ci voted on patch set 2 V -1 06/10/21, 16:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12280

  5. Christian Kuhn commented on patch set 2 06/10/21, 16:50

    foo ...
  6. Christian Kuhn uploaded patch set 3 06/10/21, 17:03

  7. core-ci voted on patch set 3 V +1 06/10/21, 17:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12282

  8. Jochen Roth voted on patch set 3 V +1 CR +1 06/10/21, 17:16

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 06/10/21, 19:24

  10. Christian Kuhn voted on patch set 3 V +2 CR +2 06/10/21, 19:25

  11. Christian Kuhn merged patch set 4 06/10/21, 19:25