69454[TASK] Avoid ObjectManager in ext:form TranslationService
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/form/Classes/Service/TranslationService.php+12 −25
- typo3/sysext/form/Tests/Unit/Controller/FormEditorControllerTest.php+10 −35
- typo3/sysext/form/Tests/Unit/Controller/FormManagerControllerTest.php+7 −20
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+1 −1
- typo3/sysext/form/Tests/Unit/Service/TranslationServiceTest.php+2 −8
Review log 811
-
Christian Kuhn uploaded patch set 1 06/10/21, 16:21
-
Christian Kuhn updated the commit message in patch set 2 06/10/21, 16:23
-
core-ci voted on patch set 1 V -1 06/10/21, 16:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12279
-
core-ci voted on patch set 2 V -1 06/10/21, 16:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12280
-
Christian Kuhn commented on patch set 2 06/10/21, 16:50
foo ... -
Christian Kuhn uploaded patch set 3 06/10/21, 17:03
-
core-ci voted on patch set 3 V +1 06/10/21, 17:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12282
-
Jochen Roth voted on patch set 3 V +1 CR +1 06/10/21, 17:16
-
Oli Bartsch voted on patch set 3 V +1 CR +1 06/10/21, 19:24
-
Christian Kuhn voted on patch set 3 V +2 CR +2 06/10/21, 19:25
-
Christian Kuhn merged patch set 4 06/10/21, 19:25