69455[TASK] Avoid ObjectManager for ext:form ProcessingRule
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Jochen Roth +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −2
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+2 −1
- typo3/sysext/form/Classes/Mvc/ProcessingRule.php+8 −47
- typo3/sysext/form/Configuration/Services.yaml+4 −0
- typo3/sysext/form/Tests/Unit/Mvc/ProcessingRuleTest.php+9 −26
Review log 68
-
Christian Kuhn uploaded patch set 1 06/10/21, 18:33
-
core-ci voted on patch set 1 V -1 06/10/21, 18:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12283
-
Christian Kuhn uploaded patch set 2 06/10/21, 18:49
-
core-ci voted on patch set 2 V +1 06/10/21, 18:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12284
-
Oli Bartsch voted on patch set 2 V +1 CR +1 06/10/21, 19:32
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 19:40
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/10/21, 19:41
-
Christian Kuhn merged patch set 3 06/10/21, 19:41