Review main Merged

69455[TASK] Avoid ObjectManager for ext:form ProcessingRule

Christian Kuhn CR +2 V +2 Normal +24 −76 updated 06/10/21, 19:41

Commit message

Inject a singleton service, makeInstance() prototypes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/10/21, 18:33

  2. core-ci voted on patch set 1 V -1 06/10/21, 18:35 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12283

  3. Christian Kuhn uploaded patch set 2 06/10/21, 18:49

  4. core-ci voted on patch set 2 V +1 06/10/21, 18:57 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12284

  5. Oli Bartsch voted on patch set 2 V +1 CR +1 06/10/21, 19:32

  6. Jochen Roth voted on patch set 2 V +1 CR +1 06/10/21, 19:40

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/10/21, 19:41

  8. Christian Kuhn merged patch set 3 06/10/21, 19:41