Review main Merged

69456[TASK] Cleanup namespace definitions in EXT:impexp templates

Oli Bartsch CR +2 V +2 Easy +1 −23 updated 06/10/21, 20:48

Commit message

This removes an invalid attribute from EXT:impexp
default layout and furthermore removes unnecessary
fluid namespace declarations, since they are defined
globally.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 10

Review log 811

  1. Oli Bartsch uploaded patch set 1 06/10/21, 19:37

  2. core-ci voted on patch set 1 V -1 06/10/21, 19:49 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12285

  3. Oli Bartsch uploaded patch set 2 06/10/21, 19:54

  4. core-ci voted on patch set 2 V +1 06/10/21, 20:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12286

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/10/21, 20:08

  6. Oli Bartsch uploaded patch set 3 06/10/21, 20:27

  7. Christian Kuhn voted on patch set 3 V +1 CR +1 06/10/21, 20:28

  8. Jochen Roth voted on patch set 3 V +1 CR +1 06/10/21, 20:33

  9. core-ci voted on patch set 3 V +1 06/10/21, 20:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12287

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 06/10/21, 20:48

  11. Oli Bartsch merged patch set 4 06/10/21, 20:48