Review main Merged

69457[BUGFIX] Fix return annotation of AbstractDomainObject->getUid()

Andreas Kienast CR +2 V +2 Easy +1 −1 updated 06/11/21, 09:55

Commit message

The method `TYPO3\CMS\Extbase\DomainObject\AbstractDomainObject->getUid()`
is declared to return either an int or null, but the annotation mentions
int only, which may cause issues with static code analysis tools.

Therefore, the annotation is adjusted to reflect both return types.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Oliver Klee +1
    • Torben Hansen +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Torben Hansen +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Andreas Kienast uploaded patch set 1 06/11/21, 08:49

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 06/11/21, 08:53

  3. core-ci voted on patch set 1 V +1 06/11/21, 08:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12297

  4. Oliver Klee voted on patch set 1 CR +1 06/11/21, 09:47

  5. Torben Hansen voted on patch set 1 V +1 CR +1 06/11/21, 09:55

  6. Oli Bartsch voted on patch set 1 V +2 CR +2 06/11/21, 09:55

  7. Oli Bartsch merged patch set 2 06/11/21, 09:55