Review main Merged

69458[TASK] Deprecate GeneralUtility::stdAuthCode

Oli Bartsch CR +2 V +2 Normal +51 −0 updated 06/11/21, 11:47

Commit message

GeneralUtility::stdAuthCode is unused since at least
v9. As more appropriate methods for generating hashes,
e.g. GeneralUtility::hmac() exists nowadays, the method
is deprecated.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Torben Hansen +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/11/21, 09:12

  2. core-ci voted on patch set 1 V +1 06/11/21, 09:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12298

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 06/11/21, 09:27

  4. Torben Hansen voted on patch set 1 V +1 CR +1 06/11/21, 09:30

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/11/21, 11:47

  6. Christian Kuhn merged patch set 2 06/11/21, 11:47