Review main Merged

69459[TASK] Deprecate GeneralUtility::rmFromList

Oli Bartsch CR +2 V +2 Normal +87 −40 updated 06/11/21, 13:37

Commit message

GeneralUtility::rmFromList is unused since v10. If at
all, this method would better belong to StringUtility.

Therefore, it's now deprecated in GeneralUtility, but
could be reimplemented in a more performant way in
StringUtility, when needed again.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 68

  1. Oli Bartsch uploaded patch set 1 06/11/21, 09:54

  2. core-ci voted on patch set 1 V +1 06/11/21, 10:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12299

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 06/11/21, 10:24

  4. Oli Bartsch uploaded patch set 2 06/11/21, 12:06

  5. core-ci voted on patch set 2 V +1 06/11/21, 12:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12302

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 06/11/21, 12:35

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 06/11/21, 13:37

  8. Andreas Kienast merged patch set 3 06/11/21, 13:37