Review main Merged

69461[TASK] Deprecate AbstractService

Christian Kuhn CR +2 V +2 Normal +60 −0 updated 06/11/21, 14:22

Commit message

Class TYPO3\CMS\Core\Service\AbstractService as part of
an ancient 'services' API has been rendered unused in
core with #88646. To further streamline the authentication
API and related helper methods, this class is marked
deprecated now.

This shouldn't have much impact for extensions in the
wild, since the API never found many usages apart from
core authentication related concerns.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 57

  1. Christian Kuhn uploaded patch set 1 06/11/21, 12:59

  2. core-ci voted on patch set 1 V +1 06/11/21, 13:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12303

  3. Oli Bartsch uploaded patch set 2 06/11/21, 14:02

  4. Oli Bartsch voted on patch set 2 V +1 CR +1 06/11/21, 14:02

  5. core-ci voted on patch set 2 V +1 06/11/21, 14:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12304

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 06/11/21, 14:22

  7. Andreas Kienast merged patch set 3 06/11/21, 14:22