69462[TASK] Avoid ObjectManager around ext:form FormDefinition
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 6
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94317-ExtformFinisherImplementations.rstnew+66 −0
- typo3/sysext/form/Classes/Domain/Factory/ArrayFormFactory.php+1 −2
- typo3/sysext/form/Classes/Domain/Finishers/AbstractFinisher.php+17 −6
- typo3/sysext/form/Classes/Domain/Finishers/FinisherInterface.php+6 −0
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+48 −25
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+11 −62
Review log 1119
-
Christian Kuhn uploaded patch set 1 06/11/21, 14:48
-
core-ci voted on patch set 1 V +1 06/11/21, 14:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12307
-
Christian Kuhn uploaded patch set 2 06/11/21, 17:01
-
core-ci voted on patch set 2 V -1 06/11/21, 17:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12314
-
Christian Kuhn uploaded patch set 3 06/11/21, 17:05
-
core-ci voted on patch set 3 V +1 06/11/21, 17:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12315
-
Christian Kuhn uploaded patch set 4 06/11/21, 17:29
-
core-ci voted on patch set 4 V +1 06/11/21, 17:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12316
-
Christian Kuhn uploaded patch set 5 06/11/21, 18:26
-
core-ci voted on patch set 5 V -1 06/11/21, 18:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12317
-
Christian Kuhn uploaded patch set 6 06/11/21, 18:47
-
core-ci voted on patch set 6 V +1 06/11/21, 18:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12318
-
Christian Kuhn uploaded patch set 7 06/11/21, 19:16
-
Christian Kuhn uploaded patch set 8 06/11/21, 19:21
-
core-ci voted on patch set 7 V +1 06/11/21, 19:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12319
-
core-ci voted on patch set 8 V +1 06/11/21, 19:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12320
-
Benni Mack voted on patch set 8 V +1 CR +1 06/12/21, 16:00
-
Anja Leichsenring voted on patch set 8 V +2 CR +2 06/12/21, 20:59
-
Anja Leichsenring merged patch set 9 06/12/21, 20:59