Review main Merged

69464[TASK] Deprecate HTTP headers manipulating methods in HttpUtility

Oli Bartsch CR +2 V +2 Normal +115 −0 updated 06/14/21, 10:31

Commit message

Following methods in HttpUtility are deprecated, since
they call `die()` / `exit()` and furthermore directly
manipulate the HTTP header via `header()`.

- `redirect()`
- `setResponseCode()`
- `setResponseCodeAndExit()`

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 811

  1. Oli Bartsch uploaded patch set 1 06/11/21, 20:43

  2. core-ci voted on patch set 1 V +1 06/11/21, 20:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12322

  3. Oli Bartsch uploaded patch set 2 06/14/21, 07:45

  4. core-ci voted on patch set 2 V +1 06/14/21, 07:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12388

  5. Christian Kuhn commented on patch set 2 06/14/21, 09:41

    minor remarks.

    Deprecation-94316-DeprecatedHTTPHeaderManipulatingMethodsFromHttpUtility.rst:67

    methodos

    Deprecation-94316-DeprecatedHTTPHeaderManipulatingMethodsFromHttpUtility.rst:72

    methods - plural
  6. Oli Bartsch commented on patch set 3 06/14/21, 09:57

    Published edit on patch set 2.
  7. Oli Bartsch commented on patch set 3 06/14/21, 09:57

    Deprecation-94316-DeprecatedHTTPHeaderManipulatingMethodsFromHttpUtility.rst:67 Reply

    Done

    Deprecation-94316-DeprecatedHTTPHeaderManipulatingMethodsFromHttpUtility.rst:72 Reply

    Done
  8. Christian Kuhn voted on patch set 3 V +1 CR +1 06/14/21, 10:06

  9. core-ci voted on patch set 3 V +1 06/14/21, 10:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12395

  10. Benni Mack voted on patch set 3 V +2 CR +2 06/14/21, 10:31

  11. Benni Mack merged patch set 4 06/14/21, 10:31