Review main Merged

69466[TASK] Remove extbase Request isCached() and setIsCached()

Christian Kuhn CR +2 V +2 Easy +0 −30 updated 06/12/21, 21:01

Commit message

To further prepare towards a PSR-7 Request in extbase
we have to get rid of as many setters as we possibly can.

Both methods isCached() and setIsCached() were marked
@internal in v10 and related to extbase internal handling.

Internal usages have been dropped when extbase introduced
PSR-7 Responses with #92502, the methods can be dropped now.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 5

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 06/12/21, 01:06

  2. core-ci voted on patch set 1 V +1 06/12/21, 01:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12326

  3. Oliver Klee voted on patch set 1 CR +1 06/12/21, 08:24

  4. Benni Mack voted on patch set 1 V +1 CR +1 06/12/21, 10:56

  5. Anja Leichsenring voted on patch set 1 V +2 CR +2 06/12/21, 21:01

  6. Anja Leichsenring merged patch set 2 06/12/21, 21:01