Review main Merged

69467[BUGFIX] Fix terms in Info > Page TSconfig

Sybille Peters CR +2 V +2 Easy +13 −13 updated 06/22/21, 19:07

Commit message

In the select list in "Info > Page TSconfig" the technical
representation of the terms (as they are used when setting
TSconfig) is now shown in brackets, e.g. [RTE.].

This is consistent with showing the technical representation
in other places in the backend, such as the page id in the
page layout or page tree, the table fields and Flexform
fields in the edit forms etc.

Where there are descriptive terms, (such as "Module: Web>Page")
a combination of the descriptive terms and the technical
terms is used, such as "Module: Web>Page [mod.web_layout.]"

The explanation "with overruling user settings" for mod is
omitted. This would make the list more cluttered and visually
distracting. If it is necessary to point this out, it
might be added as a note in the results.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 79

  1. Sybille Peters uploaded patch set 1 06/12/21, 07:58

  2. core-ci voted on patch set 1 V +1 06/12/21, 08:09 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12329

  3. Oliver Klee voted on patch set 1 CR +1 06/12/21, 08:24

  4. Sybille Peters commented on patch set 1 CR -1 06/12/21, 10:46

    I think it is better to put the text in brackets in the code, not in the translation files. These do not need to be translated and makes handling the translations easier. Also, they may change internally. I am working on this ...
  5. Sybille Peters uploaded patch set 2 06/12/21, 10:54

  6. core-ci voted on patch set 2 V +1 06/12/21, 11:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12331

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/22/21, 17:43

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 06/22/21, 19:07

  9. Christian Kuhn merged patch set 3 06/22/21, 19:07