Review main Merged

69468[TASK] Remove Web>Modules from TSconfig list

Sybille Peters CR +2 V +2 Easy +0 −7 updated 10/22/21, 14:49

Commit message

The select list in the module "Info > Page TSconfig" contained
"Module Web>Modules" in the select list. This refers to the
mod.web_modules settings.

The settings mod.web_modules are not used in the core and not
documented in the documentation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Haupt +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1114

  1. Sybille Peters uploaded patch set 1 06/12/21, 10:02

  2. Sybille Peters commented on patch set 1 CR -1 06/12/21, 10:06

    Putting this to on-hold until it can be figured out what are the conventions for extending TSconfig in extensions and what exactly was mod.web_modules for (the description is "Module: Web>Modules" which does not exist). direct_mail uses this setting: mod.web_modules.dmail: https://docs.typo3.org/p/directmailteam/direct-mail/7.0/en-us/Configuration/ConfiguringTheDirectMailModuleInPageTsconfig/Index.html
  3. core-ci voted on patch set 1 V +1 06/12/21, 10:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12330

  4. Sybille Peters marked it work in progress 09/13/21, 17:50

  5. Benni Mack uploaded patch set 2 10/21/21, 15:08

  6. Benni Mack commented on patch set 2 10/21/21, 15:09

    I'm fine with removing this in Core. Extensions can still use "mod." as well.
  7. core-ci voted on patch set 2 V +1 10/21/21, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18404

  8. Sybille Peters uploaded patch set 3 10/21/21, 18:48

  9. Sybille Peters commented on patch set 3 10/21/21, 18:50

    This change is ready for review.
    I changed it from [BUGFIX] to [TASK]. I don't know why I declared it as bug, doesn't really seem like a bug to me now.
  10. core-ci voted on patch set 3 V +1 10/21/21, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/18411

  11. Benni Mack voted on patch set 3 V +1 CR +1 10/22/21, 07:45

  12. Daniel Haupt voted on patch set 3 V +1 CR +1 10/22/21, 12:39

  13. Benni Mack voted on patch set 3 V +2 CR +2 10/22/21, 14:49

  14. Benni Mack merged patch set 4 10/22/21, 14:49