Review main Merged

69469[TASK] Remove extbase Request controllerSubpackageKey

Christian Kuhn CR +2 V +2 Normal +2 −84 updated 06/12/21, 21:07

Commit message

setControllerSubpackageKey(), getControllerSubpackageKey()
and property controllerSubpackageKey of extbase Request
are essentially an artifact from flow and unused in
v11 core. The information is only carried around at
one place but never actively used. This @internal
handling is dropped with the patch.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 5

Review log 57

  1. Christian Kuhn uploaded patch set 1 06/12/21, 13:12

  2. core-ci voted on patch set 1 V +1 06/12/21, 13:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12333

  3. Christian Kuhn updated the commit message in patch set 2 06/12/21, 13:29

  4. core-ci voted on patch set 2 V +1 06/12/21, 13:36 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12334

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/12/21, 21:04

  6. Benni Mack voted on patch set 2 V +2 CR +2 06/12/21, 21:07

  7. Benni Mack merged patch set 3 06/12/21, 21:07