Review main Merged

69470[TASK] Deprecate extbase setDispatched() and isDispatched()

Christian Kuhn CR +2 V +2 Normal +96 −15 updated 06/22/21, 10:55

Commit message

Extbase Request setDispatched() and isDispatched()
violate the PSR-7 'immutable' concept and need to fall.

With the changes from #92502 where extbase actions
usually return a ResponseInterface, together with the
deprecation of StopActionException in #94351, we don't
need this information in the Request anymore: It can
be handled internally within the dispatcher, depending
on the type of the response.

The patch deprecates the two methods in extbase request
and adapts usages towards an internal flag. We
throw a deprecation warning since the flag is needed for
b/w compat in v11, though.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 3

Files 7

Review log 1220

  1. Christian Kuhn uploaded patch set 1 06/12/21, 14:32

  2. core-ci voted on patch set 1 V -1 06/12/21, 14:43 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12335

  3. Christian Kuhn uploaded patch set 2 06/21/21, 15:28

  4. core-ci voted on patch set 2 V -1 06/21/21, 15:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12640

  5. Christian Kuhn uploaded patch set 3 06/21/21, 15:50

  6. Christian Kuhn uploaded patch set 4 06/21/21, 15:53

  7. Christian Kuhn uploaded patch set 5 06/21/21, 15:53

  8. core-ci voted on patch set 3 V +1 06/21/21, 16:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12642

  9. core-ci voted on patch set 4 V +1 06/21/21, 16:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12643

  10. core-ci voted on patch set 5 V +1 06/21/21, 16:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12644

  11. Christian Kuhn uploaded patch set 6 06/21/21, 16:46

  12. Christian Kuhn uploaded patch set 7 06/21/21, 16:48

  13. core-ci voted on patch set 6 V +1 06/21/21, 16:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12646

  14. core-ci voted on patch set 7 V +1 06/21/21, 17:01 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12647

  15. Anja Leichsenring updated the commit message in patch set 8 06/21/21, 18:22

  16. core-ci voted on patch set 8 V +1 06/21/21, 18:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12650

  17. Benni Mack voted on patch set 8 V +1 CR +1 06/21/21, 19:05

  18. Jochen Roth voted on patch set 8 V +1 CR +1 06/22/21, 10:55

  19. Christian Kuhn voted on patch set 8 V +2 CR +2 06/22/21, 10:55

  20. Christian Kuhn merged patch set 9 06/22/21, 10:55