69472[BUGFIX] Store preview of FAL Online Media in public folder
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Guido Schmechel +1
- Jan Kornblum +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Guido Schmechel +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1316
-
Benni Mack uploaded patch set 1 06/12/21, 18:40
-
Benni Mack updated the commit message in patch set 2 06/12/21, 18:42
-
Frans Saris voted on patch set 2 CR +1 06/12/21, 18:49
-
core-ci voted on patch set 1 V +1 06/12/21, 18:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12337
-
core-ci voted on patch set 2 V +1 06/12/21, 18:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12338
-
Richard Haeser voted on patch set 2 CR +1 06/14/21, 07:40
-
Benni Mack updated the commit message in patch set 3 06/29/21, 09:44
-
Jan Kornblum voted on patch set 3 CR +1 06/29/21, 10:42
-
core-ci voted on patch set 3 V +1 06/29/21, 10:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12792
-
Guido Schmechel commented on patch set 3 07/30/21, 23:20
Should we check the new folder in typo3/sysext/install/Classes/Report/InstallStatusReport.php -> getFileSystemStatus(), too ? -
Benni Mack commented on patch set 3 08/03/21, 08:32
Reply
We do have quite some folders which get created in there "on-the-fly" (= only if people use it). That's why there is the mkdir check in there. I think for this regression bugfix, I wouldn't add this to the InstallStatusReport change. -
Guido Schmechel commented on patch set 3 08/03/21, 08:38
Support for 9.5 should no longer be set. Can you please remove 9.5 from the release line? For v11 everything had worked for me.Reply
Okay. Thanks for clarification :-) -
Guido Schmechel commented on patch set 3 V +1 CR +1 08/04/21, 14:31
Ok. I see the "important". Fine for me :-) -
Oli Bartsch voted on patch set 3 V +1 CR +1 08/05/21, 01:01
-
Benni Mack voted on patch set 3 V +2 CR +2 08/05/21, 06:23
-
Benni Mack merged patch set 4 08/05/21, 06:23