Review main Merged

69476[BUGFIX] Remaining PHP 8.0 fixes for acceptance tests

Christian Kuhn CR +2 V +2 Normal +132 −68 updated 06/14/21, 11:07

Commit message

This fixes a bunch of PHP 8.0 warnings found by acceptance
testing. image processing and ext:scheduler are affected
for the main part.
This makes the ac test suite green with PHP 8.0. The
gitlab activation and another testing-framework raise
will follow with dedicated patches.
The patch brings an additional acceptance test for
install tool 'Environment->Image Processing' since
this worked well to nail lots of issues with
GifBuilder and friends.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 2541

Show 816 earlier messages
  1. Christian Kuhn uploaded patch set 1 06/12/21, 22:17

  2. core-ci voted on patch set 1 V -1 06/12/21, 22:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12351

  3. Christian Kuhn uploaded patch set 2 06/12/21, 23:09

  4. core-ci voted on patch set 2 V -1 06/12/21, 23:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12355

  5. Christian Kuhn uploaded patch set 3 06/12/21, 23:56

  6. core-ci voted on patch set 3 V -1 06/13/21, 00:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12356

  7. Christian Kuhn uploaded patch set 4 06/13/21, 00:09

  8. core-ci voted on patch set 4 V -1 06/13/21, 00:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12357

  9. Christian Kuhn rebased onto patch set 5 06/13/21, 00:41

  10. core-ci voted on patch set 5 V -1 06/13/21, 00:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12361

  11. Christian Kuhn rebased onto patch set 6 06/13/21, 01:28

  12. core-ci voted on patch set 6 V -1 06/13/21, 01:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12364

  13. Christian Kuhn rebased onto patch set 7 06/13/21, 02:14

  14. core-ci voted on patch set 7 V -1 06/13/21, 02:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12370

  15. Christian Kuhn uploaded patch set 8 06/13/21, 14:19

  16. core-ci voted on patch set 8 V -1 06/13/21, 14:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12377

  1. Christian Kuhn rebased onto patch set 9 06/13/21, 18:23

  2. core-ci voted on patch set 9 V -1 06/13/21, 18:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12379

  3. Christian Kuhn uploaded patch set 10 06/13/21, 19:38

  4. core-ci voted on patch set 10 V -1 06/13/21, 19:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12380

  5. Christian Kuhn uploaded patch set 11 06/13/21, 21:42

  6. core-ci voted on patch set 11 V +1 06/13/21, 21:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12381

  7. Christian Kuhn uploaded patch set 12 06/13/21, 21:54

  8. core-ci voted on patch set 12 V -1 06/13/21, 22:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12382

  9. Christian Kuhn uploaded patch set 13 06/13/21, 22:14

  10. Christian Kuhn uploaded patch set 14 06/13/21, 22:22

  11. Christian Kuhn commented on patch set 14 06/13/21, 22:24

    Note difference between set 13 and 14 is only the removal of the gitlab ac test activation. Set 13 is green ... gitlab change should be separate, so we can figure out a useful combination for nightlies in a dedicated patch.
  12. core-ci voted on patch set 13 V +1 06/13/21, 22:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12383

  13. core-ci voted on patch set 14 V +1 06/13/21, 22:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12384

  14. Oli Bartsch uploaded patch set 15 06/14/21, 10:45

  15. Benni Mack voted on patch set 15 V +1 CR +1 06/14/21, 10:48

  16. Christian Kuhn commented on patch set 15 06/14/21, 10:48

    IpAnonymizationAdditionalFieldProvider.php:62 Unresolved

    keep! did that by intention to test 'edit' first, then the values.
  17. Christian Kuhn commented on patch set 15 06/14/21, 10:49

    TableGarbageCollectionAdditionalFieldProvider.php:112 Unresolved

    keep!
  18. Christian Kuhn voted on patch set 15 CR -1 06/14/21, 10:53

  19. core-ci voted on patch set 15 V +1 06/14/21, 10:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12398

  20. Oli Bartsch uploaded patch set 16 06/14/21, 10:55

  21. Christian Kuhn voted on patch set 16 V +1 CR +1 06/14/21, 10:56

  22. Oli Bartsch voted on patch set 16 V +1 CR +1 06/14/21, 10:57

  23. core-ci voted on patch set 16 V +1 06/14/21, 11:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12399

  24. Benni Mack voted on patch set 16 V +2 CR +2 06/14/21, 11:07

  25. Benni Mack merged patch set 17 06/14/21, 11:07