69476[BUGFIX] Remaining PHP 8.0 fixes for acceptance tests
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 16
- typo3/sysext/backend/Classes/Backend/Shortcut/ShortcutRepository.php+1 −1
- typo3/sysext/backend/Classes/Search/LiveSearch/LiveSearch.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+2 −2
- typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php+21 −20
- typo3/sysext/core/Classes/Resource/Processing/LocalCropScaleMaskHelper.php+16 −16
- typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php+15 −4
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/Utility/GeneralUtility.php+2 −2
- typo3/sysext/core/Tests/Acceptance/Backend/InstallTool/EnvironmentCest.phpnew+47 −0
- typo3/sysext/install/Classes/Controller/EnvironmentController.php+9 −6
- typo3/sysext/recordlist/Classes/RecordList/DatabaseRecordList.php+1 −1
- typo3/sysext/reports/Classes/Task/SystemStatusUpdateTaskNotificationEmailField.php+4 −2
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+5 −5
- typo3/sysext/scheduler/Classes/Task/FileStorageIndexingAdditionalFieldProvider.php+1 −1
- typo3/sysext/scheduler/Classes/Task/IpAnonymizationAdditionalFieldProvider.php1+2 −2
- typo3/sysext/scheduler/Classes/Task/TableGarbageCollectionAdditionalFieldProvider.php1+4 −4
Review log 2541
Show 816 earlier messages
-
Christian Kuhn uploaded patch set 1 06/12/21, 22:17
-
core-ci voted on patch set 1 V -1 06/12/21, 22:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12351
-
Christian Kuhn uploaded patch set 2 06/12/21, 23:09
-
core-ci voted on patch set 2 V -1 06/12/21, 23:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12355
-
Christian Kuhn uploaded patch set 3 06/12/21, 23:56
-
core-ci voted on patch set 3 V -1 06/13/21, 00:07 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12356
-
Christian Kuhn uploaded patch set 4 06/13/21, 00:09
-
core-ci voted on patch set 4 V -1 06/13/21, 00:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12357
-
Christian Kuhn rebased onto patch set 5 06/13/21, 00:41
-
core-ci voted on patch set 5 V -1 06/13/21, 00:59 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12361
-
Christian Kuhn rebased onto patch set 6 06/13/21, 01:28
-
core-ci voted on patch set 6 V -1 06/13/21, 01:44 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12364
-
Christian Kuhn rebased onto patch set 7 06/13/21, 02:14
-
core-ci voted on patch set 7 V -1 06/13/21, 02:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12370
-
Christian Kuhn uploaded patch set 8 06/13/21, 14:19
-
core-ci voted on patch set 8 V -1 06/13/21, 14:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12377
-
Christian Kuhn rebased onto patch set 9 06/13/21, 18:23
-
core-ci voted on patch set 9 V -1 06/13/21, 18:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12379
-
Christian Kuhn uploaded patch set 10 06/13/21, 19:38
-
core-ci voted on patch set 10 V -1 06/13/21, 19:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12380
-
Christian Kuhn uploaded patch set 11 06/13/21, 21:42
-
core-ci voted on patch set 11 V +1 06/13/21, 21:52 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12381
-
Christian Kuhn uploaded patch set 12 06/13/21, 21:54
-
core-ci voted on patch set 12 V -1 06/13/21, 22:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12382
-
Christian Kuhn uploaded patch set 13 06/13/21, 22:14
-
Christian Kuhn uploaded patch set 14 06/13/21, 22:22
-
Christian Kuhn commented on patch set 14 06/13/21, 22:24
Note difference between set 13 and 14 is only the removal of the gitlab ac test activation. Set 13 is green ... gitlab change should be separate, so we can figure out a useful combination for nightlies in a dedicated patch. -
core-ci voted on patch set 13 V +1 06/13/21, 22:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12383
-
core-ci voted on patch set 14 V +1 06/13/21, 22:33 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12384
-
Oli Bartsch uploaded patch set 15 06/14/21, 10:45
-
Benni Mack voted on patch set 15 V +1 CR +1 06/14/21, 10:48
-
Christian Kuhn commented on patch set 15 06/14/21, 10:48
IpAnonymizationAdditionalFieldProvider.php:62Unresolvedkeep! did that by intention to test 'edit' first, then the values. -
Christian Kuhn commented on patch set 15 06/14/21, 10:49
TableGarbageCollectionAdditionalFieldProvider.php:112Unresolvedkeep! -
Christian Kuhn voted on patch set 15 CR -1 06/14/21, 10:53
-
core-ci voted on patch set 15 V +1 06/14/21, 10:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12398
-
Oli Bartsch uploaded patch set 16 06/14/21, 10:55
-
Christian Kuhn voted on patch set 16 V +1 CR +1 06/14/21, 10:56
-
Oli Bartsch voted on patch set 16 V +1 CR +1 06/14/21, 10:57
-
core-ci voted on patch set 16 V +1 06/14/21, 11:05 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12399
-
Benni Mack voted on patch set 16 V +2 CR +2 06/14/21, 11:07
-
Benni Mack merged patch set 17 06/14/21, 11:07