Review main Merged

69484[TASK] Raise typo3/testing-framework:^6.8.4

Christian Kuhn CR +2 V +2 Easy +9 −9 updated 06/14/21, 12:55

Commit message

Acceptance tests now properly configure graphics
magick, so image generation works for them. This
triggeres different and more relevant code paths.

composer req --dev typo3/testing-framework:^6.8.4
composer req --dev typo3/testing-framework:^6.8.4 -d typo3/sysext/core --no-update

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 06/14/21, 11:44

  2. core-ci voted on patch set 1 V +1 06/14/21, 11:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12403

  3. Christian Kuhn uploaded patch set 2 06/14/21, 12:38

  4. core-ci voted on patch set 2 V +1 06/14/21, 12:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12408

  5. Jochen Roth voted on patch set 2 V +1 CR +1 06/14/21, 12:52

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 06/14/21, 12:53

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 06/14/21, 12:55

  8. Christian Kuhn merged patch set 3 06/14/21, 12:55