Review main Merged

69486[BUGFIX] Use correct slide direction in MultiStepWizard

Oli Bartsch CR +2 V +2 Easy +2 −2 updated 06/14/21, 13:02

Commit message

Bootstrap beta3 introduced a regression, which reversed
the slide direction. This therefore broke our implementation,
since we are using an event listener, evaluating the direction.

Because we were not aware of this being "just" a regression
instead of an intended API change, we switched the direction
in our event listener in #94037, too.

In the final 5.0 release, we updated to in #94089, the regression
has been fixed, breaking our event listener once again.

This is fixed by restoring the initial and correct direction check.

Related bootstrap PRs:

- https://github.com/twbs/bootstrap/pull/32913
- https://github.com/twbs/bootstrap/pull/33499

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Nikita Hovratov +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/14/21, 11:56

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 06/14/21, 11:59

  3. core-ci voted on patch set 1 V +1 06/14/21, 12:08 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12405

  4. Nikita Hovratov voted on patch set 1 V +1 CR +1 06/14/21, 12:46

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 06/14/21, 13:01

  6. Christian Kuhn merged patch set 2 06/14/21, 13:02