Review 10.4 Merged

69488[TASK] Reflect patched jQuery state

Andreas Kienast CR +2 V +2 Normal +51 −20 updated 07/09/21, 12:51

Commit message

Documents the fact that bundled jQuery v3.4.1 actually has been patched
to reflect security changes for jQuery v3.5.1 - but besides that still
behaves like v3.4.1 in terms of backward compatibility.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Simon Gilli +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 910

  1. Andreas Kienast uploaded patch set 1 06/14/21, 13:05

  2. Andreas Kienast commented on patch set 1 CR -1 06/14/21, 13:06

    something is completely off...
  3. Andreas Kienast commented on patch set 1 CR 0 06/14/21, 13:10

    Everything is fine, by adding some comments the diff context moved and thus the diff files have more information.
  4. core-ci voted on patch set 1 V +1 06/14/21, 13:12 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12414

  5. Simon Gilli voted on patch set 1 V +1 CR +1 06/14/21, 13:14

  6. Oliver Hader commented on patch set 1 CR -1 06/14/21, 13:22

    I'll check later
  7. Andreas Kienast commented on patch set 1 07/09/21, 08:15

    @Olly were you able to check this "later"™ ;)
  8. Oliver Hader commented on patch set 1 CR +1 07/09/21, 12:46

    I could check it again in more detail next-week™, but you know how that ends... ;-) Looks good to me - go ahead!
  9. Andreas Kienast voted on patch set 1 V +2 CR +2 07/09/21, 12:51

  10. Andreas Kienast merged patch set 2 07/09/21, 12:51