Review main Merged

69490[TASK] Require symfony components with 5.3.0 or higher

Benni Mack CR +2 V +2 Hard +358 −281 updated 06/14/21, 19:25

Commit message

TYPO3 v11 will require symfony 5.3.0 (and hopefully
further versions once they will be released).

Used composer command:

> composer req -W "symfony/config:^5.3.0" \
"symfony/console:^5.3.0" \
"symfony/dependency-injection:^5.3.0" \
"symfony/expression-language:^5.3.0" \
"symfony/finder:^5.3.0" \
"symfony/http-foundation:^5.3.0" \
"symfony/mailer:^5.3.0" \
"symfony/mime:^5.3.0" \
"symfony/property-access:^5.3.0" \
"symfony/property-info:^5.3.0" \
"symfony/routing:^5.3.0" \
"symfony/var-dumper:^5.3.0" \
"symfony/yaml:^5.3.0"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 45

  1. Benni Mack uploaded patch set 1 06/14/21, 15:32

  2. core-ci voted on patch set 1 V +1 06/14/21, 15:40 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12423

  3. Christian Kuhn voted on patch set 1 V +1 CR +1 06/14/21, 16:00

  4. Benni Mack voted on patch set 1 V +2 CR +2 06/14/21, 19:24

  5. Benni Mack merged patch set 2 06/14/21, 19:25