69496[TASK] Fix various PHP8 issues
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Christian Kuhn +1
-
Verified V +2 Done
- Benni Mack +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 16
- typo3/sysext/backend/Classes/Controller/AboutController.php2+1 −1
- typo3/sysext/backend/Classes/Controller/HelpController.php+1 −1
- typo3/sysext/backend/Classes/Domain/Repository/TableManualRepository.php+9 −9
- typo3/sysext/core/Classes/Resource/AbstractFile.php+1 −1
- typo3/sysext/core/Classes/Utility/PathUtility.php2+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/PageTree/DragAndDrop/PageCreationWithDragAndDropCest.php+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/HelpCest.php+12 −0
- typo3/sysext/core/Tests/Acceptance/Backend/Topbar/SetupCest.phpnew+65 −0
- typo3/sysext/core/Tests/Unit/Utility/PathUtilityTest.php+5 −0
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php3+2 −2
- typo3/sysext/recordlist/Classes/Browser/AbstractElementBrowser.php2+5 −1
- typo3/sysext/recordlist/Classes/Browser/DatabaseBrowser.php+4 −2
- typo3/sysext/reports/Classes/Controller/ReportController.php+1 −1
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+4 −4
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php2+2 −2
Review log 2640
Show 1115 earlier messages
-
Jochen Roth uploaded patch set 1 06/15/21, 07:52
-
Jochen Roth updated the commit message in patch set 2 06/15/21, 07:54
-
core-ci voted on patch set 1 V +1 06/15/21, 08:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12442
-
core-ci voted on patch set 2 V +1 06/15/21, 08:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12443
-
Oli Bartsch commented on patch set 2 06/15/21, 08:17
-
Jochen Roth uploaded patch set 3 06/15/21, 08:47
-
Jochen Roth commented on patch set 3 06/15/21, 08:57
AbstractElementBrowser.php:147Reply UnresolvedYes, all areas i tested (form, page, ctype:abstract) 0,1,2 was set. If you think it makes sense to change it for all params just let me know. -
core-ci voted on patch set 3 V +1 06/15/21, 08:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12444
-
Christian Kuhn commented on patch set 3 06/15/21, 09:19
PathUtility.php:246pls check the unit test and add a case that would trigger a php 8 warning here. -
Christian Kuhn commented on patch set 3 06/15/21, 09:22
AboutController.php:121how did you trigger this and why did an ac test not find this?SetupModuleController.php:261how good or bad is the general coverage of ac tests of the setup module? -
Jochen Roth uploaded patch set 4 06/15/21, 09:52
-
core-ci voted on patch set 4 V +1 06/15/21, 10:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12445
-
Christian Kuhn commented on patch set 4 06/15/21, 10:06
ContentObjectRenderer.php:3506sure? how can $tsfe no be the TypoScriptFrontendController object here? -
Jochen Roth commented on patch set 4 06/15/21, 10:10
AboutController.php:121Reply UnresolvedOn the top right, "?" -> "About TYPO3 CMS"ContentObjectRenderer.php:3506Reply Unresolvediirc, this issue appeared in the reports module -
Jochen Roth uploaded patch set 5 06/15/21, 13:44
-
core-ci voted on patch set 5 V -1 06/15/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12449
-
Jochen Roth uploaded patch set 6 06/16/21, 07:14
-
core-ci voted on patch set 6 V -1 06/16/21, 07:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12477
-
Jochen Roth uploaded patch set 7 06/16/21, 07:52
-
core-ci voted on patch set 7 V -1 06/16/21, 08:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12478
-
Jochen Roth uploaded patch set 8 06/16/21, 10:54
-
core-ci voted on patch set 8 V +1 06/16/21, 11:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12483
-
Jochen Roth uploaded patch set 9 06/16/21, 11:14
-
core-ci voted on patch set 9 V +1 06/16/21, 11:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12484
-
Jochen Roth uploaded patch set 10 06/16/21, 11:52
-
Jochen Roth uploaded patch set 11 06/16/21, 12:04
-
core-ci voted on patch set 10 V -1 06/16/21, 12:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12485
-
core-ci voted on patch set 11 V -1 06/16/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12486
-
Jochen Roth uploaded patch set 12 06/16/21, 12:26
-
core-ci voted on patch set 12 V -1 06/16/21, 12:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12493
-
Jochen Roth uploaded patch set 13 06/16/21, 14:12
-
core-ci voted on patch set 13 V +1 06/16/21, 14:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12497
-
Jochen Roth commented on patch set 13 06/16/21, 14:23
PathUtility.php:246ReplyDoneSetupModuleController.php:261ReplyDone -
Benni Mack voted on patch set 13 V +1 CR +1 06/16/21, 15:24
-
Christian Kuhn uploaded patch set 14 06/16/21, 20:18
-
Christian Kuhn commented on patch set 14 06/16/21, 20:19
ContentObjectRenderer.php:5341Unresolveddrop -
Christian Kuhn commented on patch set 14 V +1 CR +1 06/16/21, 20:20
i'd solve various places differently (eg. "if ($foo['bar'] ?? false)" instead of "if ($foo['bar'] ?? null)", but that's taste. looks technically correct. -
core-ci voted on patch set 14 V +1 06/16/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12509
-
Benni Mack voted on patch set 14 V +2 CR +2 06/16/21, 20:53
-
Benni Mack merged patch set 15 06/16/21, 20:53
AbstractElementBrowser.php:147