Review main Merged

69496[TASK] Fix various PHP8 issues

Jochen Roth CR +2 V +2 Normal +115 −27 updated 06/16/21, 20:53

Commit message

In EXT:rte_ckeditor, EXT:form, EXT:recordlist,
EXT:setup, EXT:backend, EXT:frontend, EXT:reports

Added acceptance test for About and User Settings
module loading

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 2640

Show 1115 earlier messages
  1. Jochen Roth uploaded patch set 1 06/15/21, 07:52

  2. Jochen Roth updated the commit message in patch set 2 06/15/21, 07:54

  3. core-ci voted on patch set 1 V +1 06/15/21, 08:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12442

  4. core-ci voted on patch set 2 V +1 06/15/21, 08:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12443

  5. Oli Bartsch commented on patch set 2 06/15/21, 08:17

    AbstractElementBrowser.php:147

    Are we sure 0, 1 and 2 are always set?
  6. Jochen Roth uploaded patch set 3 06/15/21, 08:47

  7. Jochen Roth commented on patch set 3 06/15/21, 08:57

    AbstractElementBrowser.php:147 Reply Unresolved

    Yes, all areas i tested (form, page, ctype:abstract) 0,1,2 was set. If you think it makes sense to change it for all params just let me know.
  8. core-ci voted on patch set 3 V +1 06/15/21, 08:58 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12444

  9. Christian Kuhn commented on patch set 3 06/15/21, 09:19

    PathUtility.php:246

    pls check the unit test and add a case that would trigger a php 8 warning here.
  10. Christian Kuhn commented on patch set 3 06/15/21, 09:22

    AboutController.php:121

    how did you trigger this and why did an ac test not find this?

    SetupModuleController.php:261

    how good or bad is the general coverage of ac tests of the setup module?
  11. Jochen Roth uploaded patch set 4 06/15/21, 09:52

  12. core-ci voted on patch set 4 V +1 06/15/21, 10:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12445

  13. Christian Kuhn commented on patch set 4 06/15/21, 10:06

    ContentObjectRenderer.php:3506

    sure? how can $tsfe no be the TypoScriptFrontendController object here?
  14. Jochen Roth commented on patch set 4 06/15/21, 10:10

    AboutController.php:121 Reply Unresolved

    On the top right, "?" -> "About TYPO3 CMS"

    ContentObjectRenderer.php:3506 Reply Unresolved

    iirc, this issue appeared in the reports module
  15. Jochen Roth uploaded patch set 5 06/15/21, 13:44

  1. core-ci voted on patch set 5 V -1 06/15/21, 14:00 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12449

  2. Jochen Roth uploaded patch set 6 06/16/21, 07:14

  3. core-ci voted on patch set 6 V -1 06/16/21, 07:29 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12477

  4. Jochen Roth uploaded patch set 7 06/16/21, 07:52

  5. core-ci voted on patch set 7 V -1 06/16/21, 08:04 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12478

  6. Jochen Roth uploaded patch set 8 06/16/21, 10:54

  7. core-ci voted on patch set 8 V +1 06/16/21, 11:02 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12483

  8. Jochen Roth uploaded patch set 9 06/16/21, 11:14

  9. core-ci voted on patch set 9 V +1 06/16/21, 11:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12484

  10. Jochen Roth uploaded patch set 10 06/16/21, 11:52

  11. Jochen Roth uploaded patch set 11 06/16/21, 12:04

  12. core-ci voted on patch set 10 V -1 06/16/21, 12:05 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12485

  13. core-ci voted on patch set 11 V -1 06/16/21, 12:17 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12486

  14. Jochen Roth uploaded patch set 12 06/16/21, 12:26

  15. core-ci voted on patch set 12 V -1 06/16/21, 12:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12493

  16. Jochen Roth uploaded patch set 13 06/16/21, 14:12

  17. core-ci voted on patch set 13 V +1 06/16/21, 14:22 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12497

  18. Jochen Roth commented on patch set 13 06/16/21, 14:23

    PathUtility.php:246 Reply

    Done

    SetupModuleController.php:261 Reply

    Done
  19. Benni Mack voted on patch set 13 V +1 CR +1 06/16/21, 15:24

  20. Christian Kuhn uploaded patch set 14 06/16/21, 20:18

  21. Christian Kuhn commented on patch set 14 06/16/21, 20:19

    ContentObjectRenderer.php:5341 Unresolved

    drop
  22. Christian Kuhn commented on patch set 14 V +1 CR +1 06/16/21, 20:20

    i'd solve various places differently (eg. "if ($foo['bar'] ?? false)" instead of "if ($foo['bar'] ?? null)", but that's taste. looks technically correct.
  23. core-ci voted on patch set 14 V +1 06/16/21, 20:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12509

  24. Benni Mack voted on patch set 14 V +2 CR +2 06/16/21, 20:53

  25. Benni Mack merged patch set 15 06/16/21, 20:53