Review main Merged

69498[TASK] Deprecate extbase StopActionException

Christian Kuhn CR +2 V +2 Normal +110 −50 updated 06/15/21, 18:12

Commit message

There are three possible cases an extbase controller
action can come up with:
a) Return a casual psr-7 response (html, json, ...)
b) Return an extbase specific ForwardResponse to dispatch
   extbase-internally to another action.
c) Have a redirect the client should receive to
   call some other Url.

a) and b) are simple in v11 - the action returns a
PSR-7 ResponseInterface. c) however throws StopActionException
instead, which is caught by extbase Dispatcher and
then returned. This is ugly.

The patch changes this and deprecates the StopActionException.
We can not drop the throw call since that would be breaking,
but we prepare towards a clean v12 solution, which leads to
the sitation that *all* extbase actions return a response.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1423

  1. Christian Kuhn uploaded patch set 1 06/15/21, 13:27

  2. core-ci voted on patch set 1 V -1 06/15/21, 13:30 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12447

  3. Christian Kuhn uploaded patch set 2 06/15/21, 13:43

  4. Oli Bartsch commented on patch set 2 06/15/21, 13:53

    ActionController.php:957 Unresolved

    See comment on the return type.

    ActionController.php:961 Unresolved

    Technically, this is wrong, since this method currently does neither return null nor ResponseInterface (also PHPStrom notes "Missing 'return' statement"). I got the idea of letting people know that this will return a ResponseInterface in v12, but for now, this has to be `:void`. I'm curious whether PHPStand will report this as error.
  5. core-ci voted on patch set 2 V -1 06/15/21, 13:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12448

  6. Christian Kuhn uploaded patch set 3 06/15/21, 16:31

  7. core-ci voted on patch set 3 V -1 06/15/21, 16:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12453

  8. Christian Kuhn uploaded patch set 4 06/15/21, 16:34

  9. core-ci voted on patch set 4 V +1 06/15/21, 16:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12454

  10. Christian Kuhn uploaded patch set 5 06/15/21, 17:14

  11. Christian Kuhn uploaded patch set 6 06/15/21, 17:21

  12. core-ci voted on patch set 5 V +1 06/15/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12456

  13. Christian Kuhn uploaded patch set 7 06/15/21, 17:25

  14. Christian Kuhn uploaded patch set 8 06/15/21, 17:28

  15. core-ci voted on patch set 6 V +1 06/15/21, 17:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12457

  16. core-ci voted on patch set 7 V -1 06/15/21, 17:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12459

  17. core-ci voted on patch set 8 V -1 06/15/21, 17:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12460

  18. Christian Kuhn uploaded patch set 9 06/15/21, 17:43

  19. core-ci voted on patch set 9 V +1 06/15/21, 17:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12461

  20. Daniel Goerz voted on patch set 9 V +1 CR +1 06/15/21, 17:57

  21. Anja Leichsenring voted on patch set 9 V +1 CR +1 06/15/21, 18:02

  22. Christian Kuhn voted on patch set 9 V +2 CR +2 06/15/21, 18:11

  23. Christian Kuhn merged patch set 10 06/15/21, 18:12