69498[TASK] Deprecate extbase StopActionException
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Christian Kuhn +2
- Daniel Goerz +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-94351-ExtextbaseStopActionException.rstnew+60 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/ActionController.php2+9 −17
- typo3/sysext/extbase/Classes/Mvc/Exception/StopActionException.php+7 −0
- typo3/sysext/extbase/Classes/Mvc/Dispatcher.php+8 −0
- typo3/sysext/extensionmanager/Classes/Controller/UploadExtensionFileController.php+4 −1
- typo3/sysext/form/Classes/Domain/Finishers/RedirectFinisher.php+13 −30
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+7 −0
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+2 −2
Review log 1423
-
Christian Kuhn uploaded patch set 1 06/15/21, 13:27
-
core-ci voted on patch set 1 V -1 06/15/21, 13:30 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12447
-
Christian Kuhn uploaded patch set 2 06/15/21, 13:43
-
Oli Bartsch commented on patch set 2 06/15/21, 13:53
ActionController.php:961UnresolvedTechnically, this is wrong, since this method currently does neither return null nor ResponseInterface (also PHPStrom notes "Missing 'return' statement"). I got the idea of letting people know that this will return a ResponseInterface in v12, but for now, this has to be `:void`. I'm curious whether PHPStand will report this as error. -
core-ci voted on patch set 2 V -1 06/15/21, 13:54 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12448
-
Christian Kuhn uploaded patch set 3 06/15/21, 16:31
-
core-ci voted on patch set 3 V -1 06/15/21, 16:34 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12453
-
Christian Kuhn uploaded patch set 4 06/15/21, 16:34
-
core-ci voted on patch set 4 V +1 06/15/21, 16:46 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12454
-
Christian Kuhn uploaded patch set 5 06/15/21, 17:14
-
Christian Kuhn uploaded patch set 6 06/15/21, 17:21
-
core-ci voted on patch set 5 V +1 06/15/21, 17:24 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12456
-
Christian Kuhn uploaded patch set 7 06/15/21, 17:25
-
Christian Kuhn uploaded patch set 8 06/15/21, 17:28
-
core-ci voted on patch set 6 V +1 06/15/21, 17:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12457
-
core-ci voted on patch set 7 V -1 06/15/21, 17:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12459
-
core-ci voted on patch set 8 V -1 06/15/21, 17:41 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12460
-
Christian Kuhn uploaded patch set 9 06/15/21, 17:43
-
core-ci voted on patch set 9 V +1 06/15/21, 17:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12461
-
Daniel Goerz voted on patch set 9 V +1 CR +1 06/15/21, 17:57
-
Anja Leichsenring voted on patch set 9 V +1 CR +1 06/15/21, 18:02
-
Christian Kuhn voted on patch set 9 V +2 CR +2 06/15/21, 18:11
-
Christian Kuhn merged patch set 10 06/15/21, 18:12
ActionController.php:957Unresolved