Review main Merged

69500[TASK] Improve code tidiness in the logger

crell CR +2 V +2 Normal +116 −80 updated 06/16/21, 16:20

Commit message

Assorted cleanup and tidying of the Logger system.
There's more to do later but that's for later.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • core-ci +1 CI

Issues 2

Files 7

Review log 1623

  1. crell uploaded patch set 1 06/15/21, 22:06

  2. core-ci voted on patch set 1 V -1 06/15/21, 22:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12470

  3. crell uploaded patch set 2 06/15/21, 22:41

  4. core-ci voted on patch set 2 V -1 06/15/21, 22:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12471

  5. crell uploaded patch set 3 06/16/21, 12:10

  6. core-ci voted on patch set 3 V -1 06/16/21, 12:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12487

  7. Oliver Klee commented on patch set 3 06/16/21, 12:13

    MailerTest.php:63

    Can't we do this in a simpler way with Prophecy?
  8. crell commented on patch set 3 06/16/21, 13:13

    MailerTest.php:63 Reply

    In my experience, mocking frameworks generally make things more complicated rather than less. I've yet to run into a case where an anon class isn't easier to read, easier to maintain, and easier to auto-refactor than a mocking framework.
  9. crell uploaded patch set 4 06/16/21, 13:13

  10. Oliver Klee wrote 06/16/21, 13:16

    Removed reviewer Oliver Klee.
  11. core-ci voted on patch set 4 V +1 06/16/21, 13:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12494

  12. Christian Kuhn updated the commit message in patch set 5 06/16/21, 15:18

  13. core-ci voted on patch set 5 V +1 06/16/21, 15:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12502

  14. Benni Mack commented on patch set 5 V +1 CR +1 06/16/21, 15:46

    Nice one, finally we're cleaning up this area!
  15. Christian Kuhn commented on patch set 5 06/16/21, 15:48

    LogLevel.php:113

    should have test coverage.
  16. Christian Kuhn commented on patch set 5 06/16/21, 16:01

    LogLevel.php:113 Reply

    Done

    MailerTest.php:63 Reply

    the more often i see that, the more i like it.
  17. Christian Kuhn uploaded patch set 6 06/16/21, 16:01

  18. Christian Kuhn commented on patch set 6 V +1 CR +1 06/16/21, 16:02

    just added some tests for atLeast()
  19. Christian Kuhn uploaded patch set 7 06/16/21, 16:04

  20. core-ci voted on patch set 6 V +1 06/16/21, 16:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12504

  21. core-ci voted on patch set 7 V +1 06/16/21, 16:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12505

  22. Christian Kuhn commented on patch set 7 V +2 CR +2 06/16/21, 16:20

    Vote from benni still applies, we only added tests.
  23. Christian Kuhn merged patch set 8 06/16/21, 16:20