69500[TASK] Improve code tidiness in the logger
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
-
Verified V +2 Done
- Christian Kuhn +2
- core-ci +1 CI
Issues 2
Files 7
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+2 −2
- typo3/sysext/core/Classes/Log/Logger.php+19 −38
- typo3/sysext/core/Classes/Log/LogLevel.php2+12 −0
- typo3/sysext/core/Classes/Log/LogManager.php+21 −27
- typo3/sysext/core/Classes/Log/LogManagerInterface.php+3 −1
- typo3/sysext/core/Tests/Unit/Log/LogLevelTest.php+43 −0
- typo3/sysext/core/Tests/Unit/Mail/MailerTest.php3+16 −12
Review log 1623
-
crell uploaded patch set 1 06/15/21, 22:06
-
core-ci voted on patch set 1 V -1 06/15/21, 22:08 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12470
-
crell uploaded patch set 2 06/15/21, 22:41
-
core-ci voted on patch set 2 V -1 06/15/21, 22:53 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12471
-
crell uploaded patch set 3 06/16/21, 12:10
-
core-ci voted on patch set 3 V -1 06/16/21, 12:13 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12487
-
Oliver Klee commented on patch set 3 06/16/21, 12:13
-
crell commented on patch set 3 06/16/21, 13:13
MailerTest.php:63ReplyIn my experience, mocking frameworks generally make things more complicated rather than less. I've yet to run into a case where an anon class isn't easier to read, easier to maintain, and easier to auto-refactor than a mocking framework. -
crell uploaded patch set 4 06/16/21, 13:13
-
Oliver Klee wrote 06/16/21, 13:16
Removed reviewer Oliver Klee. -
core-ci voted on patch set 4 V +1 06/16/21, 13:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12494
-
Christian Kuhn updated the commit message in patch set 5 06/16/21, 15:18
-
core-ci voted on patch set 5 V +1 06/16/21, 15:30 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12502
-
Benni Mack commented on patch set 5 V +1 CR +1 06/16/21, 15:46
Nice one, finally we're cleaning up this area! -
Christian Kuhn commented on patch set 5 06/16/21, 15:48
LogLevel.php:113should have test coverage. -
Christian Kuhn commented on patch set 5 06/16/21, 16:01
LogLevel.php:113ReplyDoneMailerTest.php:63Replythe more often i see that, the more i like it. -
Christian Kuhn uploaded patch set 6 06/16/21, 16:01
-
Christian Kuhn commented on patch set 6 V +1 CR +1 06/16/21, 16:02
just added some tests for atLeast() -
Christian Kuhn uploaded patch set 7 06/16/21, 16:04
-
core-ci voted on patch set 6 V +1 06/16/21, 16:11 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12504
-
core-ci voted on patch set 7 V +1 06/16/21, 16:16 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12505
-
Christian Kuhn commented on patch set 7 V +2 CR +2 06/16/21, 16:20
Vote from benni still applies, we only added tests. -
Christian Kuhn merged patch set 8 06/16/21, 16:20
MailerTest.php:63