Review main Merged

69501[TASK] Extract common site test aspects to trait

Oliver Hader CR +2 V +2 Normal +69 −65 updated 06/18/21, 10:02

Commit message

Extracts TypoScript instruction handling to test trait, which enables
to reuse corresponding methods.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Oliver Hader uploaded patch set 1 06/16/21, 12:17

  2. core-ci voted on patch set 1 V +1 06/16/21, 12:27 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12488

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/16/21, 14:21

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 06/16/21, 16:07

  5. Oliver Hader voted on patch set 1 V +2 CR +2 06/18/21, 10:02

  6. Oliver Hader merged patch set 2 06/18/21, 10:02