Review main Merged

69504[TASK] Add acceptance test for EXT:reports module

Jochen Roth CR +2 V +2 Normal +60 −0 updated 06/17/21, 12:08

Commit message

This will add a basic acceptance test for
reports module because the page was not loaded
using php 8.0.
Another test is slightly changed to stabilize a
test we had a recent change in.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1118

  1. Jochen Roth uploaded patch set 1 06/16/21, 15:07

  2. Jochen Roth uploaded patch set 2 06/16/21, 15:08

  3. core-ci voted on patch set 1 V -1 06/16/21, 15:19 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12500

  4. core-ci voted on patch set 2 V -1 06/16/21, 15:21 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12501

  5. Christian Kuhn rebased onto patch set 3 06/16/21, 21:12

  6. core-ci voted on patch set 3 V +1 06/16/21, 21:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12511

  7. Christian Kuhn commented on patch set 3 V +1 CR +1 06/16/21, 21:44

    note backport pending and green already.
  8. Jochen Roth uploaded patch set 4 06/17/21, 07:58

  9. Markus Klein voted on patch set 4 V +1 CR +1 06/17/21, 08:07

  10. core-ci voted on patch set 4 V -1 06/17/21, 08:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12526

  11. core-ci voted on patch set 4 V +1 06/17/21, 09:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12526

  12. Christian Kuhn uploaded patch set 5 06/17/21, 11:53

  13. Christian Kuhn updated the commit message in patch set 6 06/17/21, 11:54

  14. Markus Klein voted on patch set 6 V +1 CR +1 06/17/21, 11:58

  15. core-ci voted on patch set 5 V +1 06/17/21, 12:04 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12534

  16. core-ci voted on patch set 6 V +1 06/17/21, 12:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12535

  17. Christian Kuhn voted on patch set 6 V +2 CR +2 06/17/21, 12:08

  18. Christian Kuhn merged patch set 7 06/17/21, 12:08