Review main Merged

69505[BUGFIX] Return ForwardResponse in belog's deleteMessageAction

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 06/17/21, 11:14

Commit message

The action `deleteMessageAction` of the controller
`\TYPO3\CMS\Belog\Controller\BackendLogController` now returns a proper
`ForwardResponse` to keep the desired redirect behavior.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Andreas Kienast uploaded patch set 1 06/17/21, 06:45

  2. core-ci voted on patch set 1 V -1 06/17/21, 06:47 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12524

  3. Andreas Kienast uploaded patch set 2 06/17/21, 06:48

  4. core-ci voted on patch set 2 V +1 06/17/21, 06:59 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12525

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/17/21, 08:41

  6. Benni Mack voted on patch set 2 V +2 CR +2 06/17/21, 11:14

  7. Benni Mack merged patch set 3 06/17/21, 11:14