Review main Abandoned

69510[TASK] Introduce phpstan-baseline.neon

Alexander Schnitzler CR 0 V 0 Hard +288 −224 updated 10/19/21, 11:15

Commit message

Using a baseline file for all specific errors (the ones with
a message, count and path) makes it easier to keep the list
of ignored errors up to date and it does not longer require
manual changes. Instead, the files is managed/written by

    phpstan --generate-baseline

The main configuration file - phpstan.neon - must only contain
very generic error excludes.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 56

  1. Alexander Schnitzler uploaded patch set 1 06/17/21, 11:48

  2. Alexander Schnitzler wrote 06/17/21, 11:48

    Topic set to phpstan
  3. core-ci voted on patch set 1 V -1 06/17/21, 11:57 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12533

  4. Christian Kuhn commented on patch set 1 09/11/21, 15:05

    the strategy to use 'phpstan --generate-baseline' won't work well since the baseline depends on php version and we need different configs per php version, right? how to continue here?
  5. Christian Kuhn commented on patch set 1 10/19/21, 11:15

    Hey. I fear the proposed solution does not work out well at the moment, especially due to the different php versions and partially different excludes we have to set based on this. I hope it's fine to abandon this approach for now and see how this evolves. Feel free to resurrect the patch if you have an idea on how to solve it.
  6. Christian Kuhn abandoned the change 10/19/21, 11:15