Review main Merged

69512[TASK] Allow CSV Export per table in list module

Benni Mack CR +2 V +2 Hard +237 −55 updated 06/18/21, 16:28

Commit message

This change moves the CSV Export in the header of each
table within the record list.

This contains multiple UX improvements:

* CSV Exports are now possible in each list view, not just
  in single table view
* CSV Export Buttons are visually connected to the actual
  records and the output
* The CSV Button now has a proper label next to the icon
  instead of just an icon in the docheader

In addition, the RecordListController is thinned out as all
logic is separated and moved into a new RecordExportController.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1419

  1. Benni Mack uploaded patch set 1 06/17/21, 14:51

  2. core-ci voted on patch set 1 V -1 06/17/21, 15:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12545

  3. Benni Mack updated the commit message in patch set 2 06/17/21, 15:30

  4. core-ci voted on patch set 2 V -1 06/17/21, 15:40 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12548

  5. Daniel Goerz uploaded patch set 3 06/17/21, 15:49

  6. core-ci voted on patch set 3 V +1 06/17/21, 16:03 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12550

  7. Oli Bartsch uploaded patch set 4 06/17/21, 17:05

  8. Oli Bartsch uploaded patch set 5 06/17/21, 17:11

  9. core-ci voted on patch set 4 V +1 06/17/21, 17:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12558

  10. Oli Bartsch voted on patch set 5 V +1 CR +1 06/17/21, 17:17

  11. core-ci voted on patch set 5 V +1 06/17/21, 17:19 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12559

  12. Tymoteusz Motylewski commented on patch set 5 06/17/21, 20:15

    Can we call it a "feature"? otherwise it will not get enough attention
  13. Benni Mack commented on patch set 5 06/17/21, 20:46

    Reply

    There is more to come (in my opinion): A new modal to modify the filename, and to select between all columns or selected columns, and between processed values and raw DB records. I would say then this is even a user-friendly feature.
  14. Christian Kuhn commented on patch set 5 CR -1 06/18/21, 16:15

    RecordListController.php:141

    bug. still used.
  15. Christian Kuhn commented on patch set 5 CR 0 06/18/21, 16:27

    RecordListController.php:141 Reply

    scratch that ... comes from line 122 already.
  16. Christian Kuhn commented on patch set 5 06/18/21, 16:27

    RecordListController.php:141 Reply

    Done
  17. Jochen Roth voted on patch set 5 V +1 CR +1 06/18/21, 16:28

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 06/18/21, 16:28

  19. Christian Kuhn merged patch set 6 06/18/21, 16:28