Review main Merged

69515[TASK] Avoid ObjectManager in ext:form FormRuntime

Christian Kuhn CR +2 V +2 Normal +107 −94 updated 06/18/21, 17:14

Commit message

Most ObjectManager->get() calls in FormRuntime can
be moved to makeInstance() directly without further
impact. For FormFactoryInterface, a b/w compat layer
is established, but shouldn't be problematic since
this will be ArrayFormFactory in almost all cases.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 2

Files 10

Review log 79

  1. Christian Kuhn uploaded patch set 1 06/17/21, 21:14

  2. core-ci voted on patch set 1 V +1 06/17/21, 21:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12564

  3. Christian Kuhn updated the commit message in patch set 2 06/17/21, 21:44

  4. core-ci voted on patch set 2 V +1 06/17/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12566

  5. Benni Mack voted on patch set 2 CR +1 06/18/21, 11:06

  6. Jochen Roth voted on patch set 2 V +1 CR +1 06/18/21, 14:38

  7. Anja Leichsenring voted on patch set 2 V +1 CR +1 06/18/21, 17:01

  8. Christian Kuhn voted on patch set 2 V +2 CR +2 06/18/21, 17:14

  9. Christian Kuhn merged patch set 3 06/18/21, 17:14