69515[TASK] Avoid ObjectManager in ext:form FormRuntime
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Anja Leichsenring +1
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- Anja Leichsenring +1
- core-ci +1 CI
Issues 2
Files 10
- typo3/sysext/form/Classes/Controller/FormEditorController.php+1 −3
- typo3/sysext/form/Classes/Domain/Finishers/FinisherContext.php+4 −17
- typo3/sysext/form/Classes/Domain/Model/FormDefinition.php+11 −7
- typo3/sysext/form/Classes/Domain/Renderer/FluidFormRenderer.php+1 −1
- typo3/sysext/form/Classes/Domain/Runtime/FormRuntime.php+50 −28
- typo3/sysext/form/Classes/ViewHelpers/RenderViewHelper.php+12 −6
- typo3/sysext/form/Configuration/Services.yaml+12 −0
- typo3/sysext/form/Documentation/I/ApiReference/Index.rst+2 −2
- typo3/sysext/form/Documentation/I/Concepts/FrontendRendering/Index.rst+4 −4
- typo3/sysext/form/Tests/Unit/Domain/Runtime/FormRuntimeTest.php+10 −26
Review log 79
-
Christian Kuhn uploaded patch set 1 06/17/21, 21:14
-
core-ci voted on patch set 1 V +1 06/17/21, 21:25 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12564
-
Christian Kuhn updated the commit message in patch set 2 06/17/21, 21:44
-
core-ci voted on patch set 2 V +1 06/17/21, 21:55 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12566
-
Benni Mack voted on patch set 2 CR +1 06/18/21, 11:06
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/18/21, 14:38
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 06/18/21, 17:01
-
Christian Kuhn voted on patch set 2 V +2 CR +2 06/18/21, 17:14
-
Christian Kuhn merged patch set 3 06/18/21, 17:14