Review main Merged

69517[BUGFIX] Respect offline storages on context menu initialization

Oli Bartsch CR +2 V +2 Easy +6 −3 updated 06/18/21, 10:04

Commit message

The FileProvider tries to retrieve the file / folder object
on initialization. In case the requested folder or storage
is temporarily offline, a ResourceDoesNotExistException
is thrown.

This is now fixed by catching the exception an setting
the $record to NULL. This allows to still render the
context menu with the remaining options, such as edit
the storage record or display the records information.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 06/18/21, 08:17

  2. core-ci voted on patch set 1 V +1 06/18/21, 08:28 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12572

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/18/21, 08:57

  4. Jochen Roth voted on patch set 1 V +1 CR +1 06/18/21, 09:05

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 06/18/21, 10:04

  6. Oli Bartsch merged patch set 2 06/18/21, 10:04