Review main Abandoned

69518[BUGFIX] Fix access legend on Permission detail view

Oli Bartsch CR 0 V 0 Normal +57 −65 updated 06/18/21, 15:44

Commit message

The detail view in the permission module did only
display a subset of the actual access legend, which
is shown on the list view.

This is fixed as both templates now use the same
new "AccessLegend" partial.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 68

  1. Oli Bartsch uploaded patch set 1 06/18/21, 11:00

  2. Oli Bartsch updated the commit message in patch set 2 06/18/21, 11:02

  3. core-ci voted on patch set 1 V +1 06/18/21, 11:13 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12578

  4. core-ci voted on patch set 2 V +1 06/18/21, 11:15 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12579

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/18/21, 15:32

  6. Jochen Roth voted on patch set 2 V +1 CR +1 06/18/21, 15:33

  7. Christian Kuhn commented on patch set 2 V 0 CR -1 06/18/21, 15:39

    actually, that doesn't make sense on detail view since the icon phalanx isn't used there. imho: drop legend on detail altogether.
  8. Oli Bartsch abandoned the change 06/18/21, 15:44

    Change makes no sense as Christian noted. However, the explanation of the permission titles, e.g. what does "Edit content" mean, is IMO still helpful in this view. Therefore I'll just abandon this patch.