Review main Merged

69521[BUGFIX] Missing is_array check in setValueByPath

TYPO3com CR +2 V +2 Easy +44 −1 updated 06/22/21, 10:40

Commit message

PHP Warning: array_key_exists() expects parameter 2 to be
array, null given in ArrayUtility.php line 297, when an
longer path than exists in given array is set.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • crell +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. TYPO3com uploaded patch set 1 06/18/21, 12:34

  2. core-ci voted on patch set 1 V +1 06/18/21, 12:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12583

  3. Christian Kuhn commented on patch set 1 CR -1 06/18/21, 13:54

    on it.
  4. Christian Kuhn uploaded patch set 2 06/18/21, 14:07

  5. Christian Kuhn updated the commit message in patch set 3 06/18/21, 14:11

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 06/18/21, 14:11

  7. Jochen Roth voted on patch set 3 V +1 CR +1 06/18/21, 14:12

  8. core-ci voted on patch set 2 V +1 06/18/21, 14:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12589

  9. core-ci voted on patch set 3 V +1 06/18/21, 14:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12590

  10. crell commented on patch set 3 CR +1 06/18/21, 22:51

    I can't think of any improvements that wouldn't require PHP 7.4, and the tests seem good.
  11. Christian Kuhn voted on patch set 3 V +2 CR +2 06/22/21, 10:40

  12. Christian Kuhn merged patch set 4 06/22/21, 10:40