69521[BUGFIX] Missing is_array check in setValueByPath
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- crell +1
-
Verified V +2 Done
- Christian Kuhn +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 2
Review log 812
-
TYPO3com uploaded patch set 1 06/18/21, 12:34
-
core-ci voted on patch set 1 V +1 06/18/21, 12:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12583
-
Christian Kuhn commented on patch set 1 CR -1 06/18/21, 13:54
on it. -
Christian Kuhn uploaded patch set 2 06/18/21, 14:07
-
Christian Kuhn updated the commit message in patch set 3 06/18/21, 14:11
-
Christian Kuhn voted on patch set 3 V +1 CR +1 06/18/21, 14:11
-
Jochen Roth voted on patch set 3 V +1 CR +1 06/18/21, 14:12
-
core-ci voted on patch set 2 V +1 06/18/21, 14:18 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12589
-
core-ci voted on patch set 3 V +1 06/18/21, 14:21 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12590
-
crell commented on patch set 3 CR +1 06/18/21, 22:51
I can't think of any improvements that wouldn't require PHP 7.4, and the tests seem good. -
Christian Kuhn voted on patch set 3 V +2 CR +2 06/22/21, 10:40
-
Christian Kuhn merged patch set 4 06/22/21, 10:40