69523[BUGFIX] Allow logging and formatting of all Throwables
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 5
- typo3/sysext/core/Classes/Log/Writer/AbstractWriter.php+1 −4
- typo3/sysext/core/Classes/Log/Writer/DatabaseWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/FileWriter.php+2 −2
- typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php+1 −1
- typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php+1 −1
Review log 1013
-
crell uploaded patch set 1 06/18/21, 19:22
-
Christian Kuhn commented on patch set 1 06/18/21, 19:32
-
core-ci voted on patch set 1 V +1 06/18/21, 19:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12593
-
crell updated the commit message in patch set 2 06/18/21, 19:44
-
core-ci voted on patch set 2 V +1 06/18/21, 19:56 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12594
-
Helmut Hummel commented on patch set 2 V -1 06/20/21, 14:57
The following lines need to be adapted as well, so that throwables are in fact be properly logged: https://github.com/TYPO3/TYPO3.CMS/blob/b28ab075067aee6371d909e36ffef30053f006b3/typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php#L39 https://github.com/TYPO3/TYPO3.CMS/blob/b28ab075067aee6371d909e36ffef30053f006b3/typo3/sysext/core/Classes/Log/Writer/FileWriter.php#L140 https://github.com/TYPO3/TYPO3.CMS/blob/b28ab075067aee6371d909e36ffef30053f006b3/typo3/sysext/core/Classes/Log/Writer/DatabaseWriter.php#L69 https://github.com/TYPO3/TYPO3.CMS/blob/b28ab075067aee6371d909e36ffef30053f006b3/typo3/sysext/core/Classes/Log/Writer/SyslogWriter.php#L113 besides https://github.com/TYPO3/TYPO3.CMS/blob/b28ab075067aee6371d909e36ffef30053f006b3/typo3/sysext/core/Classes/Log/Writer/PhpErrorLogWriter.php#L40 seems to be obsolete, as $message is overwritten a few lines below -
crell commented on patch set 2 06/21/21, 15:26
Reply
Yep, good catch. Updated. -
crell uploaded patch set 3 06/21/21, 15:27
-
core-ci voted on patch set 3 V +1 06/21/21, 15:37 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12639
-
Benni Mack commented on patch set 3 CR +1 06/24/21, 13:53
Looks good. Will also test -
Benni Mack voted on patch set 3 V +1 06/25/21, 07:07
-
Christian Kuhn voted on patch set 3 V +2 CR +2 06/27/21, 13:55
-
Christian Kuhn merged patch set 4 06/27/21, 13:55
Unresolved