69525[TASK] Avoid ObjectManager in remaining ext:form places
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 3
Files 7
- typo3/sysext/form/Classes/Domain/Model/FormElements/AbstractSection.php+2 −5
- typo3/sysext/form/Classes/Domain/Model/Renderable/AbstractRenderable.php+1 −3
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/UploadedFileReferenceConverter.php+1 −1
- typo3/sysext/form/Classes/Mvc/Property/PropertyMappingConfiguration.php+2 −5
- typo3/sysext/form/Tests/Unit/Domain/Finishers/RedirectFinisherTest.php+0 −7
- typo3/sysext/form/Tests/Unit/Domain/FormElements/AbstractSectionTest.php+3 −12
- typo3/sysext/form/Tests/Unit/Mvc/Property/PropertyMappingConfigurationTest.php+0 −159
Review log 68
-
Christian Kuhn uploaded patch set 1 06/18/21, 22:38
-
Christian Kuhn updated the commit message in patch set 2 06/18/21, 22:41
-
core-ci voted on patch set 1 V +1 06/18/21, 22:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12597
-
core-ci voted on patch set 2 V +1 06/18/21, 22:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12598
-
Benni Mack voted on patch set 2 CR +1 06/21/21, 08:30
-
Jochen Roth voted on patch set 2 V +1 CR +1 06/21/21, 12:33
-
Benni Mack voted on patch set 2 V +2 CR +2 06/21/21, 12:35
-
Benni Mack merged patch set 3 06/21/21, 12:35