Review main Merged

69533[TASK] Remove unused ext:core AbstractCondition

Christian Kuhn CR +2 V +2 Normal +1 −60 updated 06/21/21, 11:59

Commit message

Core Configuration\TypoScript\ConditionMatching\AbstractCondition
is an old TypoScript condition leftover, unused and can be
removed without further notice:

It has been added in with #61489 in v7 - own condition classes
for TypoScript, superseded with #85829 in v9 - symfony
expressions for TypoScript conditions, old syntax has
been deprecated in v9 with #86068 and removed in v10
with #87607.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 6

Files 2

Review log 45

  1. Christian Kuhn uploaded patch set 1 06/19/21, 11:28

  2. core-ci voted on patch set 1 V +1 06/19/21, 11:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12604

  3. Benni Mack voted on patch set 1 V +1 CR +1 06/21/21, 10:55

  4. Oli Bartsch voted on patch set 1 V +2 CR +2 06/21/21, 11:59

  5. Oli Bartsch merged patch set 2 06/21/21, 11:59