Review main Merged

69536[BUGFIX] Fix error where tsconf_alphaSort is undefined

Jochen Roth CR +2 V +2 Normal +85 −4 updated 06/22/21, 11:04

Commit message

When a user opens Info -> Page TSconfig it will throw
an error "Undefined array key tsconf_alphaSort".

Fixed by adding 0 as fallback to the array access.
Another test was added which checks if modules in the
toolbar dropdown are callable.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1013

  1. Jochen Roth uploaded patch set 1 06/21/21, 14:09

  2. core-ci voted on patch set 1 V -1 06/21/21, 14:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12633

  3. Jochen Roth uploaded patch set 2 06/21/21, 16:27

  4. core-ci voted on patch set 2 V +1 06/21/21, 16:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12645

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 06/22/21, 10:13

  6. Oli Bartsch commented on patch set 2 CR -1 06/22/21, 10:27

    This sounds like an exception, preventing me from using the module. Actually only a PHP warning is displayed in a flash message.
    checks
    Full stop missing.

    BackendLogModuleBootstrap.php:43

    Seems to be unrelated to this patch.

    InfoPageTyposcriptConfigController.php:220

    Parameter $alphaSort of ext_getObjTree() should be string, possible int given.

    InfoPageTyposcriptConfigController.php:222

    Parameter $currentValue should be string|bool, possible int given.
  7. Christian Kuhn commented on patch set 2 06/22/21, 10:35

    Reply Unresolved

    it *is* an exception in dev-mode ...

    BackendLogModuleBootstrap.php:43 Reply Unresolved

    not unrelated: git checkout origin/master typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php Build/Scripts/runTests.sh -s acceptance -p 8.0 typo3/sysext/core/Tests/Acceptance/Backend/Info/InfoModuleCest.php ->fails.
  8. Jochen Roth uploaded patch set 3 06/22/21, 10:37

  9. Jochen Roth commented on patch set 3 06/22/21, 10:39

    Reply

    Done

    Reply

    Done

    InfoPageTyposcriptConfigController.php:220 Reply

    Done

    InfoPageTyposcriptConfigController.php:222 Reply

    Done
  10. Oli Bartsch voted on patch set 3 V +1 CR +1 06/22/21, 10:43

  11. core-ci voted on patch set 3 V +1 06/22/21, 10:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12661

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 06/22/21, 11:04

  13. Christian Kuhn merged patch set 4 06/22/21, 11:04