69536[BUGFIX] Fix error where tsconf_alphaSort is undefined
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 4
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php2+1 −1
- typo3/sysext/core/Tests/Acceptance/Backend/Info/InfoModuleCest.phpnew+80 −0
- typo3/sysext/core/Tests/Acceptance/Support/Extension/BackendCoreEnvironment.php+2 −1
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php4+2 −2
Review log 1013
-
Jochen Roth uploaded patch set 1 06/21/21, 14:09
-
core-ci voted on patch set 1 V -1 06/21/21, 14:24 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12633
-
Jochen Roth uploaded patch set 2 06/21/21, 16:27
-
core-ci voted on patch set 2 V +1 06/21/21, 16:39 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12645
-
Christian Kuhn voted on patch set 2 V +1 CR +1 06/22/21, 10:13
-
Oli Bartsch commented on patch set 2 CR -1 06/22/21, 10:27
This sounds like an exception, preventing me from using the module. Actually only a PHP warning is displayed in a flash message.checksFull stop missing.BackendLogModuleBootstrap.php:43Seems to be unrelated to this patch.InfoPageTyposcriptConfigController.php:220Parameter $alphaSort of ext_getObjTree() should be string, possible int given.InfoPageTyposcriptConfigController.php:222Parameter $currentValue should be string|bool, possible int given. -
Christian Kuhn commented on patch set 2 06/22/21, 10:35
Reply Unresolved
it *is* an exception in dev-mode ...BackendLogModuleBootstrap.php:43Reply Unresolvednot unrelated: git checkout origin/master typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php Build/Scripts/runTests.sh -s acceptance -p 8.0 typo3/sysext/core/Tests/Acceptance/Backend/Info/InfoModuleCest.php ->fails. -
Jochen Roth uploaded patch set 3 06/22/21, 10:37
-
Jochen Roth commented on patch set 3 06/22/21, 10:39
Reply
DoneReply
DoneInfoPageTyposcriptConfigController.php:220ReplyDoneInfoPageTyposcriptConfigController.php:222ReplyDone -
Oli Bartsch voted on patch set 3 V +1 CR +1 06/22/21, 10:43
-
core-ci voted on patch set 3 V +1 06/22/21, 10:48 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12661
-
Christian Kuhn voted on patch set 3 V +2 CR +2 06/22/21, 11:04
-
Christian Kuhn merged patch set 4 06/22/21, 11:04