Review main Merged

69537[FEATURE] Improved Multi-selection of Files

Benni Mack CR +2 V +2 Normal +187 −48 updated 07/01/21, 08:39

Commit message

This change is the first of a few areas to unify the selection
and multi-action logic of lists in TYPO3 Backend.

This change moves the checkbox to the very beginning
of each row within the File Browser popup
(e.g. Select a File in Pages > Media of Form Engine)

In addition to the "toggle selection" button, there is now
a "select all" and "select none" button.

When an item is selected, the whole
item is now marked as selected.

This code now uses the TYPO3 icons instead
of the Font Awesome icons.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 1322

  1. Benni Mack uploaded patch set 1 06/21/21, 15:36

  2. core-ci voted on patch set 1 V -1 06/21/21, 15:38 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12641

  3. Benni Mack uploaded patch set 2 06/21/21, 20:17

  4. core-ci voted on patch set 2 V -1 06/21/21, 20:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12654

  5. Benni Mack uploaded patch set 3 06/30/21, 08:12

  6. core-ci voted on patch set 3 V -1 06/30/21, 08:15 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12838

  7. Benni Mack uploaded patch set 4 06/30/21, 17:07

  8. core-ci voted on patch set 4 V -1 06/30/21, 17:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12863

  9. Oli Bartsch uploaded patch set 5 06/30/21, 18:21

  10. core-ci voted on patch set 5 V +1 06/30/21, 18:31 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12867

  11. Oli Bartsch uploaded patch set 6 06/30/21, 20:38

  12. core-ci voted on patch set 6 V +1 06/30/21, 20:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12874

  13. Benni Mack uploaded patch set 7 06/30/21, 20:56

  14. core-ci voted on patch set 7 V +1 06/30/21, 21:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12876

  15. Benni Mack updated the commit message in patch set 8 07/01/21, 06:19

  16. core-ci voted on patch set 8 V +1 07/01/21, 06:29 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12886

  17. Benni Mack uploaded patch set 9 07/01/21, 07:38

  18. core-ci voted on patch set 9 V +1 07/01/21, 07:50 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12887

  19. Jochen Roth voted on patch set 9 V +1 CR +1 07/01/21, 08:20

  20. Oli Bartsch voted on patch set 9 V +1 CR +1 07/01/21, 08:29

  21. Benni Mack voted on patch set 9 V +2 CR +2 07/01/21, 08:39

  22. Benni Mack merged patch set 10 07/01/21, 08:39