Review main Merged

69539[BUGFIX] Fix "hideTable" check in RecordListController

Oli Bartsch CR +2 V +2 Easy +3 −3 updated 06/22/21, 13:01

Commit message

Since the method has to return true in case the page
translations should be displayed, the TCA "hideTable"
check must be negated. This would otherwise lead to
page translations not being displayed if the "hideTable"
key is not defined in pages TCA. Furthermore, the TSconfig
option "hideTable" also contains the `table.` key.

Note: Only master is affected as backport was not yet
merged and will therefore contain the correct check.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 911

  1. Oli Bartsch uploaded patch set 1 06/22/21, 10:57

  2. Christian Kuhn commented on patch set 1 CR +1 06/22/21, 11:01

    foo ... didn't spot that in my review. sorry.
  3. Jochen Roth voted on patch set 1 V +1 CR +1 06/22/21, 11:05

  4. core-ci voted on patch set 1 V +1 06/22/21, 11:06 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12663

  5. Oli Bartsch commented on patch set 1 CR -1 06/22/21, 11:07

    Need to check another something.
  6. Oli Bartsch uploaded patch set 2 06/22/21, 11:11

  7. core-ci voted on patch set 2 V +1 06/22/21, 11:23 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12664

  8. Benni Mack voted on patch set 2 V +1 CR +1 06/22/21, 11:45

  9. Jochen Roth voted on patch set 2 V +1 CR +1 06/22/21, 12:42

  10. Oli Bartsch voted on patch set 2 V +2 CR +2 06/22/21, 13:01

  11. Oli Bartsch merged patch set 3 06/22/21, 13:01